Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pipe_overlong_path fails on AIX #4231

Open
abmusse opened this issue Nov 17, 2023 · 2 comments
Open

test: pipe_overlong_path fails on AIX #4231

abmusse opened this issue Nov 17, 2023 · 2 comments
Labels

Comments

@abmusse
Copy link
Contributor

abmusse commented Nov 17, 2023

  • Version: Current v1.x branch
  • Platform: AIX

Discovered this failure while running the CI for a pull request:

Ref: #4229

https://ci.nodejs.org/job/libuv-test-commit-aix/nodes=aix72-ppc64/2279/console

not ok 199 - pipe_overlong_path
# exit code 393222
# Output from process `pipe_overlong_path`:
# Assertion failed in test/test-pipe-bind-error.c on line 175: `UV_EINVAL == uv_pipe_bind2(&pipe, path, sizeof(path), UV_PIPE_NO_TRUNCATE)` (-22 == -86)

ASSERT_EQ(UV_EINVAL,

Looks like errno 86 maps to ENAMETOOLONG on AIX.

Looks like this passes as expected on IBM i:

ok 199 - pipe_overlong_path

https://ci.nodejs.org/job/libuv-test-commit-aix/nodes=aix72-ppc64/2279/console

@richardlau richardlau added the aix label Nov 17, 2023
@bnoordhuis
Copy link
Member

What is the size of struct sockaddr_un.sun_path on AIX?

@abmusse
Copy link
Contributor Author

abmusse commented Dec 21, 2023

@bnoordhuis

What is the size of struct sockaddr_un.sun_path on AIX?

Looks like its set to 1024 or 1023

From: /usr/include/sys/un.h

#if defined(COMPAT_43) && !defined(_KERNEL)
struct  sockaddr_un {
        ushort_t        sun_family;     /* AF_UNIX */
        char        sun_path[1024]; /* changed from 104 to PATH_MAX to support long user names. This value should be ch
anged manually if PATH_MAX changes in future */
};
#else
struct  sockaddr_un {
        uchar_t     sun_len;            /* sockaddr len including null */
        sa_family_t sun_family;         /* AF_UNIX */
        char        sun_path[1023]; /* changed from 104 to PATH_MAX to support long user names. This value should be ch
anged manually if PATH_MAX changes in future */
};
#endif /* COMPAT_43 && !_KERNEL */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants