Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring event attributes. #125

Open
4 of 5 tasks
HexDecimal opened this issue Jan 2, 2023 · 0 comments
Open
4 of 5 tasks

Refactoring event attributes. #125

HexDecimal opened this issue Jan 2, 2023 · 0 comments
Assignees

Comments

@HexDecimal
Copy link
Collaborator

HexDecimal commented Jan 2, 2023

Events are a mess right now and need to be cleaned up. Multiple bad ideas need to be deprecated and removed in a way which allows for backwards compatibility.

  • Fix case in window event types as they do not match the type hints.
  • Rename mouse pixel attributes to just position and motion in preparation to removing their tile attributes.
  • Context.convert_event should return a new event with updated positions instead of editing events in place.
  • A new function needs to be added to convert coordinates when contexts are not available.
  • Deprecate tile attributes in mouse events.
@HexDecimal HexDecimal self-assigned this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant