DRZ80 not working

[wn2000]

Originally posted by @wn2000 in #766 (comment)

[mahoneyt944]

Are you testing this with the current core? This core now has core options to force enable these modes.

[mahoneyt944]

If you force enable one of these modes, check the info log that it replaced the CPU

mame2003-plus-libretro/src/mame2003/mame2003.c

Line 1693 in ee777f2

log_cb(RETRO_LOG_INFO, LOGPRE "Replaced Z80\n");

[wn2000]

To be clear there are two issues:

1. The bug on these lines prevents the CPU replacement (as it's comparing a pointer address against an enum):

mame2003-plus-libretro/src/mame2003/mame2003.c

Line 1690 in ee777f2

if (type==CPU_Z80)

mame2003-plus-libretro/src/mame2003/mame2003.c

Line 1704 in ee777f2

if (type==CPU_Z80 && Machine->drv->cpu[i].cpu_flags&CPU_AUDIO_CPU)

2. After fixing this bug (so the log correctly shows "Replaced Z80"), some sound effects are missing (tested with sdfight before and after the fix).
   So there's some issue with the original PR that added the DrZ80 support.

[mahoneyt944]

It's possible the replacement CPU isn't fully compatible as the original. I'd assume this would be a case by case type of thing. Are the replacement cpus working at all after your fix?... to confirm the replaced cpu is operational at least even if buggy?

The core option allows you to replace a main z80 CPU, z80 sound CPU, or both....so there maybe specific combo that works better for some games than others.

[wn2000]

Yeah so it seems DrZ80 doesn't work at all. Tried 88 games, with Cyclone+DrZ80 it freezes at the ROM OK screen; with Cyclone only it works fine.
But Cyclone also has issues. AvP would black screen if Cyclone is enabled.

So, maybe not worth it after all.

[arcadez2003]

Yeah as i commented at the time they were first supported here the cyclone cpu cores are buggy for a fair few games
but boost up the performance of many others hence we turned off the cyclone's by default and make them a toggle
option via the menus.

i suppose back in the day a list would have been made as to which games should be played using it and which should
not but no one can be bothered with such undertakings nowadays :)

[wn2000]

Looks like cyclone received some updates recently:

https://github.com/notaz/cyclone68000/commits/master/

[grant2258]

This was a strange one. I deleted the mame2003 plus folder and done a fresh git clone compiled it and 88 games works. I think the git might be locking or some other odd behavior on the retropie I installed it is old but its the latest on their website. Try deleting your mame source directory and grab it again then recompile. Ive included the retropie bin 4.8 I compiled if you using that.

mame2003_plus_libretro.so.zip