WIP Audit "Fixing Up" and "Adding More" Custom OSTs:) #1451
Comments
|
Good reference list. I can pretty much convert / debug any of these into 2003+. Figured we'd finalize contra next? But we can do them in any order you prefer. Definitely a cool mod....I think in the long run though we should explore some solutions to getting these samples available to the public. I'm not sure who operates some of the sample source sites available now, but maybe one of those would be interested in hosting the OST samples? |
|
Also, if you didn't already, I updated the robocop samples. This will require you to fix the sample name typos in Xtreme and renumber the play calls since the duplicate intro sample was removed. There wasn't much done, beside light editing of the samples and some volume equalization but I think it sounds pretty good all and all. |
|
@mahoneyt944 I wouldn't worry so much about the hosting, til we are pretty set on these Custom OSTs. But, I have a good idea of where they can be posted, and can worry about that when the time comes. I will check out RoboCop:) Thanks again! And, I will check back in this feed for follow-ups. |
|
@KMFDManic I have contra converted over. Did you have samples for this one yet or did you want me to create some? |
|
@mahoneyt944 I have Contra samples partially done. You're welcome to pick some songs out, if you'd like, and we can scratch that one off of the list, as well. Ikari worked out great with your choices:) Hopefully, you like the Shinobi sample set I put together. |
|
@KMFDManic It now supports sample fading as well. Still need to finalize the samples for this, but the functionality is all there. I found there's almost 1 to 1 samples available for contra from contra evolution and super contra. Do you have any particular preferences on these? I can build a full set of samples pretty easily for this one with true split channels. Figured it might be easier to rename the samples also to there actual stage names such as "jungle" instead of stage1 etc. As long as you're ok with it I'll finalize the samples by the weekend. Or however you prefer otherwise. |
|
@mahoneyt944 I'll have to link u to a few samples I uses in my test video for it. But, essentially, I've always felt Crysis was a spiritual successor to Contra, in the way that they both start out as human as a game can get...Then, they get increasingly alien in nature. For Contra, which clearly has a first stage and protagonist based off of Predator, with Arnold Swarzeneggar, I feel a nice Predator theme remix would fit the first stage. Samples, you can let me know what feels best for you. Actually, I list the samples I used in my Contra demonstration: Feel free to be as creative as u want. You did exceptionally well with Ikari:)! |
|
@KMFDManic Maybe you can add Captain Commando to your list. |
|
@KMFDManic After scanning the sound samples with the latest dat files the following results were obtained. |
|
-02 is the right channel audio. When it's missing and -01(left channel) samples are available it will push the left channel to both speakers or vise versa. |
I have compared the waveforms of the two channels in the stereo sound sample file and can see that -01 and -02 are not simply two identical audio, perhaps the producers felt that stereo was not suitable for these games? |
|
01 and 02 are left and right mono samples which were split from stereo, they have slight differences in tone, echo, reverb, sometimes different instrumental tracks etc but overall are fairly close. That said, most left and right channels can be enjoyed even without their complimentary channel being available. The main reason someone may choose to do this, is because the samples are quite large and the platform they are using may not have enough memory to use a full set. Cutting a full set of samples to only 01 samples for instance, cuts the memory usage and storage requirement in half at the cost of true stereo. The core is designed to push a single mono sample to both speakers in the event that it's counterpart sample is not available. This effectively stimulates stereo with the benefits mentioned above. So yes using only 01 samples isn't true stereo but can still be a good option for those trying to push performance out of lower spec hardware. Some of the new sample packs that are WIP only have 01 available currently and are used for testing purposes. |
|
the sf2 i got from a certain archive was stereo if you arent going to release stereo samples remove the 02 samples :) |
|
@MistyDreams ikari was redone and I'm currently rebuilding the contra pack now. |
|
@MistyDreams Might be a good idea to edit your last post, as it refers to a site with copyrighted content that would violate github's rules. As far as the samples of -01, -02, having "dormant" coding for more advanced future use, was the primary goal with that. Depending on WHICH platform, some are only capable of supporting Mono Samples, as they would crash from running out of memory, attempting to run STEREO. There was far less interesting in Custom Samples, initially. But, with more and more platforms showing interest, "STEREO" options are more viable, nowadays:) I also greatly appreciate your tremendous support in help with anything MAME, related! @mahoneyt944 I greatly appreciate your interest in this project, for sure! You have truly made an impact on things. Looking forward to your opinion on Contra. I can help with any of the remaining OST, custom samples wise. It is refreshing and nice to have more creative output with them, as well, such as what you've shown with Ikari, etc, thus far! @SumavisionQ5 Capcom Samples can be a little finicky to work with, and we were hoping to get Forgotten Worlds/Strider implemented, and go from there. As of now, the coding needs fixed up a bit for those 2 specifics. But, I am very familiar with Captain Commando. I enjoyed playing the Capcom Collections/Generations, etc, over the years:) |
|
@KMFDManic never posted any links just mentioned the site, but if thats an issue there are links here directly providing the samples in this issue. It will be problematic finding the right samples since hosting them could cause issues. Hopefully something can be done for users. maybe stereo and mono release packs with crcs. |
|
@MistyDreams Referencing that exact site has caused problems with Reddit, Discord, etc, in the past, as it is very arguably and unquestionably "illegal" (hosting does not warrant legal downloading), and can lead to potential legal issues if people believe it is legitimate to freely download from, which is why I avoid usage of it. It has also caused controversy on other github repos, when brought up, since many mistakenly believe it is a safe download resource. Ultimately, we would find a free hosting site, to post the mono/stereo samples of, which would be a safer bet. |
|
@KMFDManic never knew an archive site would be an issue have seen it mentioned all over the place. I Wouldnt mention any direct links to it anyway is good to know. I would say the same can be said about most hosting sites just that one makes easier searches. |
|
@MistyDreams That is a huge and common misconception, which you, yourself, are also now running into. This is really no different than sites that were widely mentioned, then had takedowns and computers seized, and so on, due to copyright infringement. 30 seconds on THAT site shows they are breaking the law by not "utilizing quality control" to ensure violations are not occurring. Nintendo, Sega, Sony, have "current" "digital" sold games on there, which absolutely breaks laws regarding legal downloads. Generally, it is up to the End User to "buy" games legally, then "dump" them legally. Being that I am part of several projects that get decent exposure, as is MAME 2003 Plus, Libretro, in general. It isn't the wisest idea to promote sites that have copyright infringed downloads that are very grey area. It can look quite bad for any and all involved. This has been something I have been dealing with for 2+ decades in various projects I have been part of. When being a part of any project that gets exposure, it is best to try to remain within the confines of the law, as none of us want legal trouble, nor drama:) I have personally seen more than a few ignore such warnings, and end up being made examples of by Nintendo, and so on. It definitely is not a pretty thing to have a lawsuit slapped upon you by Nintendo, for 1 Million Plus dollars, as you would have no way out, but to declare bankruptsy. We are here to help people run stuff, not break the law in the process:) |
|
we are talking about sample sets here not current ninetendo games. Nintendo aint going to be bothering people for downloading unrelated sample sets. The same rule apllies anywhere dont post direct links. |
|
Anyone going to that site would see it hosts copyrighted files that are grey area, is what I am meaning. The sample sets can easily be hosted elsewhere, to avoid legal drama and/or trouble. Referencing a site with potentially illegal content, despite it also having legal content can lead to a lot of trouble. Being that I have faced drama first hand, from unscrupulous competition in the past, I choose to stay on a clean path, with the End User being responsible for what is on their end. I certainly have no need to reference or link to a site that infringes and hurts companies. If someone spends years and makes a homebrew game, and then it is "illegally" posted on THAT site. Anyone grabbing the samples there, might think. Hey, maybe so and so game is here, too. Then, we essentially enabled them to download games they shouldn't be downloading, and became an accessory to law breaking. This can be argued all day and night. But, at the end, why bother, when it is easier to just not promote breaking of the law to begin with:) I try to get my real life responsibilities done, then help people enjoy emulation. But, if it is going to come to a point where I am involved in any sort of "enabling" of copyright infringement, I would rather completely separate myself from any given project. It simply isn't worth chancing any legal repercussions for myself, nor any of you. |
|
Well emulation contents is a gray area. I dont really care about that site per say. I will agree contents for emulation could be argued day and night. |
|
In a different reality, I would love laws to be more forgiving when it comes to "obsolete", never to be seen again games, like anyone else. Look how long it took for Winnie the Pooh to become public domain, heh. And, the very first thing someone did was turn it into a slasher film! Imagine the day when Mario DOES become public domain, probably far after OUR time. Anyone could use Mario, but the hat he wears, a few other signature things, might still be protected. But, anyone and everyone COULD make a Mario Game, Movie, etc. In any case, to try to get back on track, it would probably be best to delete references to that Site, and just make it more agreeable with a neutral hosting link, that would not potentially infringe upon Nintendo, Sega, Sony, etc. No matter what it comes down to, you CAN grab Nintendo Switch Games there, which is in no way, shape, or form, legal:) Remember when a certain torrent site tried to protect its self interests by starting their own government on an island, haha:)? |
|
i reworded it already dont think I had to personally. I just dont feel strongly about it. I can see you do though. |
|
This is not just about me. This is the whole big picture. You really think Libretro would want any reputation for promoting of piracy within their sub repos? and, based on previous drama I have previously dealt with, as mentioned above...it simply isn't worth taking such a risk, whatsoever. In a nutshell, I started trying to fix up and work with Cores, Libretro Wise, around 2016. Soon after that, Competition arrived on the Scene, who essentially made it their number one goal to try to remove me from said Scene, and prevent me from having stuff, such as Custom OSTs in MAME, and so on. Imagine if I would have given in, and let them win? We would not have ANY Custom OSTs in 2003 Plus, and Xtreme would not even exist. These people have resorted to tactics, such as bringing the drama directly to Libretro in Discord, and even "reporting" violations of licenses that weren't even violated. Promoting Piracy is just not something not worth taking a risk with, given how malicious and evil people can be, at times. Byuu, who was a great coder, recently committed suicide, after being relentlessly harrassed and bullied online. The site that was the catalyst for this, is now "pretty much done", as a seemingly direct result of that. Many choose to hide behind keyboards and cause trouble for others online. I see no reason to be a part of any of that, especially by promoting piracy, and automatically making myself, or anyone else involved a potential target for legal prosecution. arcadez2003, as well as grant2258 have also seen their share of drama in RetroPie, as well as Libretro Scenes. And, I wish neither of them had! But, it is inevitable to run into confrontations, at some point. In my case, my Repo was "forked", and attempts were made to "ban" me and prevent me from doing anything Xtreme Wise, Custom OSTs, etc. In the end, many great and fantastic people showed support, and were still working on some more fun and Xtreme Stuff for MANY Cores, not just MAME:)! And, those who caused the trouble have "shamefully" exited the Scene without much of a word. In the end, @MistyDreams I appreciate all you do. But, I also do not want you, nor anyone else involved in THIS project to ever have to worry about legal drama. That is what it really comes down to. |
|
Most of the drama isint legal its cancel culture gone wrong. 99% of license violations complaint come from people with no authority ie only copyrights holders and contributors have a say with any authority. Its bitter people wanting something for themselves or there own motives to attack others. Anyway still dont think I committed a massive crime. |
|
@KMFDManic - I always felt mum's the word with basically anything emulation. I think if guys like you didn't work "gray" areas we wouldn't have many classics. I guess I was under the impression even sound samples are copyright infringement without written consent or owning it here in the US. Or at a minimum some of the material pulled from commercially sold CD/DVDs or OSTs, like "The Warriors". It's such an iconic classic from the late 70s. I do have the soundtrack and the movie so I'm good to go. I guess I was thinking the very content in question (i.e. -- samples, song and music bytes) are just as much a violation as any hosting site would be just as liable as those churning them out! It sounds like you had some experience with it, can you clarify that the samples are indeed legal to obtain and be in our possession for these OSTs? Aren't samples protected by default as an extension of the game or as pointed out above rips from commercial media or commercial OSTs? I hope to make one thing abundantly clear. Growing up I didn't have two nickels to rub together and when "warez" and BBS's hit the scene I was all over and didn't give it a 2nd thought. I guess I still don't give a shit today, just being honest. Hasn't everyone at one point in their lives downloaded questionable content/programs/music, even if temporary, when short on funding?! ;) With that being said I love the work you do and wouldn't sell anyone out, for any of this. I just never felt that strongly about it. It seems petty and just isn't worth the time, at all, in any capacity. I can enjoy the content you churn out or write letters trying to "troll" folks...hmmm...that's a no brainer! :) Any way thanks for all the hard work and amazing "arcade enrichment" you bring to the emulation scene!!! I think you started something amazing and please do keep going. I just figured if there was something to clarify easily that doesn't require reading between the lines or a gray area it could be useful information. |
|
Well not sure pretty sure commercial music is copyrighted it could be an issue. Hosting certainly would be for copyrighted stuff I guess. I know the mame sample set has zero issues for whatever reasons. The bottom line is the samples are linked here. I mentioned my sf2 was stereo cause the op had missing samples. It lead to this Im not heavily involved in big projects might be worth asking libretro about the samples. |
|
@KMFDManic - Just to be clear. I completely and whole heartedly respect your point of view and would definitely adhere to any requests or suggestions you make when it comes to how to handle the custom OST samples. I agree with following forum rules. I just wasn't aware you felt so strongly about it. @MistyDreams - I always wondered why MAME samples are so openly shared. I can't help it, I just "slant" toward sharing all, for lack of better words... the greater good! ;) I have to get this out of my system. I have to say I've enjoyed watching your work on this core and can't help to think you have a "fire" in ya that reminds me of grant2258, not saying it's you at all, but feisty ya be fur sure! ;) |
|
There's definitely gray area..... I mean weird al made a career out of using other people's music, with his own customizations. One could argue that we are parodying the original tracks since we do edit the original tracks to use here. I know with the samples I've worked on the tracks are split, cut, edited, faded, filtered etc to fit the game better. There's probably a line of "fair use" around this .... I feel arguments can be made for both sides but I'm not trying to fight that fight either. @MistyDreams replying to your comment about mame samples specifically, I've always assumed these are not copyright material since these are recreations or newly created captures of original sounds, but they are not the original sounds themselves. Like recording a live concert maybe. Or when a band covers another bands song etc. |
|
First you want to make sure the function is hooked up correctly. You can replace the sound call you're working on with the bool function and add some test code or logging in the bool function to verify that the sound triggers are being successfully sent to the bool function. Once you have them they can be processed/ modded. The new system defines these functions in ost_samples.h and includes that in any file using ost support. |
|
the maximun i got it working is like muting the game.. no sfx and no custom music playing.... |
|
If you remove the sound latch, you'll lose sound. So the bool function needs to return when it should latch default sounds or ignore them to play custom tracks |
|
and battletoads arcade is a weird game is not hackable .. i tried... |
|
i know the bool goes on taitosnd.h like bool game_plying = false; plus in here "#include taitosnd.h" im planning to go to ur ost_samples.c and h... but i put smash tv on the wrong spot whre mk was located.. |
|
if i get rastan working i can get the rest working.. |
|
Part of how I hook up the new way is a function ost_support_enabled mame2003-plus-libretro/src/ost_samples.h Line 24 in 0b9309d And MDRV_INSTALL_OST_SUPPORT mame2003-plus-libretro/src/ost_samples.h Line 27 in 0b9309d Which installs and checks for a value for each ost we support. Or in other words an identifier. This removes the game_playing bool used prior. This also passes a reference for machine to use outside the driver. These identifiers are just a simple enum which allows for easy updates and additions. mame2003-plus-libretro/src/ost_samples.h Lines 7 to 21 in 0b9309d If you are hooking up a new function and losing sound. You probably are not returning the original sound latch at all. Your bool function needs to return true when you want default sounds to play or false when you're ignoring original sounds. This is why the switch functions mame2003-plus-libretro/src/ost_samples.c Lines 1515 to 1517 in 0b9309d This logic can be found all over the code base here as well for the hook. mame2003-plus-libretro/src/drivers/outrun.c Lines 700 to 705 in f34453a |
|
i managed to make offroad and rastan work in one file..... |
|
now igot smash tv working with ur ost_samples method.... |
|
OMg hacking that batman game using ur ost_samples.h i had to use it in 3 files... |
|
oh in batman i use the Batman ost from the movie 1989 with michael keaton and her... Kim Basinger |
|
mahoney i want to ask you one more question..on how to fix battletoads..if its possible.. is snes i can change that but here on mame ..no clue..maybe not possible.... |
|
It would seem that it's masking the data. So you'd have to determine if there's a common factor or bitwise conversion taking place there. Kind of a trial and error approach... or see if the documentation in the source file gives you any clues. |
|
i thin k i found it WRITE16_HANDLER( BSMT2000_data_0_w ) |
|
then sdome taito games are ok to hack like rastan or ninja warriors |
|
its done battletoads i got it woking..no more 1-1-1-1-1-1-7-11-16 now some taito gamesare like impossible to hack like darius 3 screen or superman.. |
|
is there a way to fix data inmame games... that data work form the driver..not the rom...right? music starts from 0A =10 ,0B =11 ,0c =12 0D = 13 ,0E=14,0F=15, |
|
Not all games we support are fully working so that adds issues when trying to hack things. |
|
yes ur right...jackal is in the same spot..is the mame team how created the drivers.. it needs improvement.. |
|
i tried to hack killer instinct... that is terrible.. it has the values where it goes .. but has the same problem with sfx too |
|
Are the Contra OST samples completed yet? |
|
The set I use is left channel only. can't remember if @KMFDManic had a copy or not available. |
|
it is weird: contra.zip (samples) were added to mame2003plius months ago. |
|
@ac3nl to be fair, this is a WIP. The functionality for contra now works in this core, but the sample set is not yet complete. We have sets that are used for testing.... Distribution of these files it also illegal, so that's problematic. |
|
mahoney i cant make narc work on ost_samples i need to know ..to make it work it needs modifications like somebody did on NbaJam..? |
|
i got it working instead of 0x01 it was FF01..but the game dont mute..is playing dual music |
|
@kurrono if you get original and ost sound simultaneously then you either are not cancelling the original sound correctly or you have the wrong trigger value. Try blocking the original sound before adding more sound over top to ensure you have the correct values |
|
i tried that already..it doesnt work.....the arcade remains with the original music intact..changing those values |
|
any updates about contra.zip sample files? |
@ac3nl you're welcome to help finish up any sample sets that are incomplete. It mostly comes down to creatively choosing what to replace the default tracks with. Dat.wise, is somewhat insignificant in this case, as you can technically run about any sample you want to run. If we agreed on a solid sample set for any given game, such as has already been done for final fight, etc, then the dat would be more practical. |
@mahoneyt944 @MistyDreams @kurrono
To keep things nicely aligned, here is a quick Audit of where we stand with the Custom OSTs. I will edit this first post, accordingly, as we update things! If any "samples" zips need to change, let me know @mahoneyt944 , so that I can have the audited files correct for Xtreme, as well as Plus:) Anyone else following this feed is welcome to join in on the discussion! Audiophiles are welcome to help "finalize some of the OSTs!
Personal Thanks, Arcadez2003, Big Blue Frontend, Gpstar81, Grant2258,
Added Source for OSTs, 2003 Xtreme
https://github.com/KMFDManic/mame2003-xtreme
The text was updated successfully, but these errors were encountered: