[3DS] [Cheevos] Cannot disable Achievement Badges

[SKmaric]

Description

The Achievement Badges menu option is absent, but even with the config setting cheevos_badges_enable = "false", badges are still being downloaded. causing emulation stuttering.

Expected behavior

RetroAchievements badges should not be downloaded while the setting is set to off.

Actual behavior

Cheevos badges are being downloaded and displayed regardless of setting, causing stuttering.

Steps to reproduce the bug

1. Ensure cheevos_badges_enable in retroarch.cfg is set to false.
2. Run any game/core with achievement support.
3. Game will stutter as it downloads badges and displays achievement notifications.

Version/Commit

You can find this information under Information/System Information

• RetroArch: 1.18.0 / Apr 25 2024

Environment information

• OS: New 3DS XL

[Jamiras]

cheevos_badges_enable is not available if HAVE_GFX_WIDGETS is defined. Did that maybe change for the 3DS build?

RetroArch/menu/menu_setting.c

Lines 21608 to 21625 in d310f83

	#ifndef HAVE_GFX_WIDGETS
	if (string_is_equal(settings->arrays.menu_driver, "xmb") || string_is_equal(settings->arrays.menu_driver, "ozone"))
	CONFIG_BOOL(
	list, list_info,
	&settings->bools.cheevos_badges_enable,
	MENU_ENUM_LABEL_CHEEVOS_BADGES_ENABLE,
	MENU_ENUM_LABEL_VALUE_CHEEVOS_BADGES_ENABLE,
	false,
	MENU_ENUM_LABEL_VALUE_OFF,
	MENU_ENUM_LABEL_VALUE_ON,
	&group_info,
	&subgroup_info,
	parent_group,
	general_write_handler,
	general_read_handler,
	SD_FLAG_ADVANCED
	);
	#endif

RetroArch/cheevos/cheevos_client.c

Lines 2113 to 2123 in d310f83

	#if !defined(HAVE_GFX_WIDGETS) /* we always want badges if widgets are enabled */
	settings_t* settings = config_get_ptr();
	/* User has explicitly disabled badges */
	if (!settings->bools.cheevos_badges_enable)
	return;
	/* badges are only needed for xmb and ozone menus */
	if (!string_is_equal(settings->arrays.menu_driver, "xmb") &&
	!string_is_equal(settings->arrays.menu_driver, "ozone"))
	return;
	#endif /* !defined(HAVE_GFX_WIDGETS) */

As best as I can tell, it's been that way for years.

I did notice there's some logic there related to xmb/ozone that should be extended for glui as well (added in #14390).

[Ramon731]

Did this end up having a resolution? I’m trying to disable the badge download as well. You have to leave the console for a few minutes to load the badges, if I can disable there will be no waiting.