Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Unknown ISP on standard ISP #603

Closed
GerdRuetten opened this issue Mar 10, 2024 · 9 comments
Closed

Always Unknown ISP on standard ISP #603

GerdRuetten opened this issue Mar 10, 2024 · 9 comments

Comments

@GerdRuetten
Copy link

Description

I using speedtest as docker compose in the latest version (and testing with dev-branch).
I using the servers.json from your side.
On all ISP i get "Unknown ISP".
Only my own ISP (Deutsche Glasfaser) / Testserver is show me up

Server

Docker compose with:

version: '3.7'
services:
  speedtest:
    container_name: speedtest
    image: ghcr.io/librespeed/speedtest:latest
    restart: always
    environment:
      MODE: dual
      TITLE: "Speedtest - ruetten.ovh"
      TELEMETRY: "true"
      ENABLE_ID_OBFUSCATION: "false"
      REDACT_IP_ADDRESSES: "false"
      PASSWORD: "password"
      EMAIL: "gerd@ruetten.ovh"
      DISABLE_IPINFO: "false"
      DISTANCE: "km"
      WEBPORT: 8686
    ports:
      - "8686:8686" # webport mapping (host:container)
    volumes:
      - ./data/database:/database
      - ./data/servers.json:/servers.json

Client

Chrome

Steps to reproduce

You can test it under:
https://speedtest.ruetten.ovh

Expected behaviour

Resolve the ISP

Screenshots

image

My own ISP/Testserver

image image
@sstidl
Copy link
Collaborator

sstidl commented Mar 14, 2024

I think you need to set your own api key for ispinfo
IPINFO_APIKEY=XXXX
in the compose file

@Razuuu
Copy link

Razuuu commented May 3, 2024

My ISP is "Telefónica Germany Gmbh & Co OHG" and i am using librespeed.org. It says Unknown ISP.
https://librespeed.org/results/?id=0cetf22
IPInfo.io says: org:"AS6805 Telefonica Germany GmbH & Co.OHG",

grafik

@sstidl
Copy link
Collaborator

sstidl commented May 4, 2024

My ISP is "Telefónica Germany Gmbh & Co OHG" and i am using librespeed.org. It says Unknown ISP. https://librespeed.org/results/?id=0cetf22 IPInfo.io says: org:"AS6805 Telefonica Germany GmbH & Co.OHG",

grafik

This means that the provider of the service there has to use a new API key.

@sstidl
Copy link
Collaborator

sstidl commented May 4, 2024

I tested more of the hosts at librespeed.org
@adolfintel they all showed unknown IP.
So maybe you have to renew the API key used at your side?
On my private deployment it works correctly with my own key.

@adolfintel
Copy link
Member

@sstidl The problem is ipinfo itself.

They offered a free unlimited API key a few years ago to this project and all was fine until a few months ago when it started being limited like any other key. I tried contacting their support and had no response. I guess they're no longer offering free keys to open source projects?

@sstidl
Copy link
Collaborator

sstidl commented May 4, 2024

@adolfintel
I registered and got my own free plan API key. Maybe you need to register again?

You cannot share the key but use it in your deployment at librespeed.org

@adolfintel
Copy link
Member

@sstidl No, the key they gave us was specifically for this kind of use.

The agreement was that the key was available for free for librespeed.org and individual users of the project, while I would direct businesses to buy a key from them.

It was changed once due to abuse a few years ago, but it was still a free and unlimited key for users of LS.

What bothers me is that they didn't even warn me about this change, it just happened from one day to the next, and they didn't even answer my email. I don't have time to get rid of ipinfo from the project right now, but if anyone wants to do it, I highly encourage to replace it with a local database or something.

@sstidl
Copy link
Collaborator

sstidl commented May 4, 2024

I just checked the code. You just have to remove the API key from config and it should work.
They have a public API without API key.
I alread fixed that a time ago in

if (empty($IPINFO_APIKEY)) {

so https://ipinfo.io/8.8.8.8/json is the best you can get without an account. but this should be enough information?

@sstidl
Copy link
Collaborator

sstidl commented May 18, 2024

@adolfintel i close this issue as it is explained how to fix the situation.

@sstidl sstidl closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants