Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media controls notification still there #5833

Open
3 tasks done
Ehab-d opened this issue Mar 28, 2024 · 5 comments · May be fixed by #6063
Open
3 tasks done

Media controls notification still there #5833

Ehab-d opened this issue Mar 28, 2024 · 5 comments · May be fixed by #6063
Labels
bug Something isn't working help wanted Looking for help

Comments

@Ehab-d
Copy link

Ehab-d commented Mar 28, 2024

Steps to reproduce

  1. Open a YouTube video
  2. Close LibreTube from Recents
  3. Media controls notification still there

Expected behavior

The media controls notification should disappear after closing the app from the Recents.

Actual behavior

The media controls notification still remains. You have to dismiss the notification manually.

LibreTube version

0.22.2

Android version

Android 10

Other details

A screen record to clarify the issue.

Record_2024-03-28-20-45-08.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Bnyro
Copy link
Member

Bnyro commented May 8, 2024

#5998 attempts to fix this by improving the code that's running when the app is being killed, please try the latest builds form https://github.com/libre-tube/NightlyBuilds and report back if the issue still exists.

@Ehab-d
Copy link
Author

Ehab-d commented May 8, 2024

Thanks. I have tried LibreTube 0.23.1 and Nightly Builds as well and can confirm the issue persists.
The issue is not about killing the app in general. It can be reproduced by simply closing the player.

LibreTube_0.23.1_.5833.mp4

@Ehab-d
Copy link
Author

Ehab-d commented May 8, 2024

However, I see improvement in the code, as it has been resolved #5958 for me. 🚀

@Bnyro
Copy link
Member

Bnyro commented May 8, 2024

Hmm, I noticed that some other apps have the issue with the notification too (AntennaPod, VibeYou, and probably more). Not really sure how we can resolve that :/

@Bnyro Bnyro added help wanted Looking for help and removed priority: low labels May 8, 2024
@Ehab-d
Copy link
Author

Ehab-d commented May 8, 2024

No problem. You will be able to resolve it one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Looking for help
Projects
None yet
2 participants