Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Add IPv6 tests to transport integration tests #2510

Open
MarcoPolo opened this issue Aug 23, 2023 · 5 comments
Open

Feature request: Add IPv6 tests to transport integration tests #2510

MarcoPolo opened this issue Aug 23, 2023 · 5 comments
Assignees
@CtrlAltGiri
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue

Comments

@MarcoPolo
Copy link
Contributor

We should add IPv6 versions to the the transportsToTest var in p2p/test/transport/transport_test.go so that we test each transport with IPv6.
@MarcoPolo MarcoPolo added good first issue Good issue for new contributors exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue labels Aug 23, 2023
@CtrlAltGiri
Copy link

@MarcoPolo I'd love to take this

@MarcoPolo
Copy link
Contributor Author

Please do, Thanks! Let me know if you run into any questions

@MarcoPolo MarcoPolo mentioned this issue Aug 25, 2023
Merged
@CtrlAltGiri CtrlAltGiri mentioned this issue Aug 27, 2023
Closed
@ajaygupta112
Copy link

@MarcoPolo is this issue open for taking?

@sukunrt
Copy link
Member

sukunrt commented Mar 4, 2024

@ajaygupta112 Yes!
You can start here: https://github.com/libp2p/go-libp2p/pull/2531/files#diff-54f6226e2cf835d8f4f664f08e1e9a325aaa75d1bf9384c89f3c66fbd5ff8ae7

To begin with, you can enable just the Ping test for ip6.

@ajaygupta112
Copy link

@sukunrt Alright, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CtrlAltGiri CtrlAltGiri

Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MarcoPolo @sukunrt @CtrlAltGiri @ajaygupta112