Upnp port is not re-announced

[master255]

@marten-seemann There is a serious problem with upnp port announcement.

Turn on the application (Libp2p application where there is upnp announcement). Upnp port is announced on the router. It is announced every minute.
Then turn off the internet connection in the router settings or pull the wire out of the router (emulate a real internet disconnection). Then turn on the Internet.
Check upnp ports. There are none. And, even after 5 minutes they do not appear.
This presents a serious problem. Because the stability of the internet connection is very bad all over the world (I checked).

[p-shahi]

@master255 Thanks for raising the issue but please do not tag Marten or individual maintainers directly. Tagging
individual maintainers is not necessary since everyone subscribed to the repo already get notifications for GitHub issues.
I've labeled this as needs/triage and someone on the team will investigate it (and we will discuss this in the next libp2p maintainers call) Thanks

[master255]

Ok

[master255]

As I understand the result of our discussion - we need to fix it.

[marten-seemann]

Discussed in the triage meeting. This will require debugging the UPnP code. It seems reasonable to periodically renew the UPnP mapping. Not sure if it's possible to trigger the renewal faster to be able to recover from this situation faster after a disconnect.

Fixing this issue won't be a priority for the libp2p stewards, but we'd be happy to review a PR.

[master255]

I was able to fix it easily. Maybe it is necessary to do something else? #2583