Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libnifalcon.pc file even if pkg-config executable doesn't exist #61

Open
ryandesign opened this issue Jul 26, 2021 · 2 comments · May be fixed by #64
Open

Install libnifalcon.pc file even if pkg-config executable doesn't exist #61

ryandesign opened this issue Jul 26, 2021 · 2 comments · May be fixed by #64

Comments

@ryandesign
Copy link

On UNIX systems, CMakeLists.txt looks for the pkg-config executable and only if it is found does it generate and install the libnifalcon.pc file. As far as I can tell you never use the pkg-config executable so there is no need to check for its existence. Just always generate and install libnifalcon.pc on UNIX.

@ryandesign
Copy link
Author

Which is as simple as:

--- CMakeLists.txt.orig	2016-07-04 16:07:21.000000000 -0500
+++ CMakeLists.txt	2021-07-26 12:05:28.000000000 -0500
@@ -106,8 +106,6 @@
 
 #pkg-config (use the CPack information)
 IF(UNIX)
-  FIND_PACKAGE(PkgConfig)
-  if(PKG_CONFIG_EXECUTABLE)
     set(PC_SHORT_NAME "libnifalcon")
     set(PC_LONG_NAME "libnifalcon")
     set(PC_LIBRARY_NAME "libnifalcon")
@@ -133,5 +131,4 @@
       )
     set(PKG_CONFIG_DIR "${LIBRARY_INSTALL_DIR}/pkgconfig")
     install(FILES ${PC_CONFIGURED_FILE} DESTINATION ${PKG_CONFIG_DIR})
-  endif(PKG_CONFIG_EXECUTABLE)
 ENDIF()

@qdot
Copy link
Member

qdot commented Jul 26, 2021

Pull requests are usually a little more useful than diffs?

ryandesign added a commit to ryandesign/libnifalcon that referenced this issue Jul 26, 2021
@ryandesign ryandesign linked a pull request Jul 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants