Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support libavif 1.0 in CMake build #867

Open
kmilos opened this issue Sep 6, 2023 · 5 comments
Open

Support libavif 1.0 in CMake build #867

kmilos opened this issue Sep 6, 2023 · 5 comments
Labels

Comments

@kmilos
Copy link

kmilos commented Sep 6, 2023

Because of the SameMajorVersion libavif CMake config file policy the latest 1.0.x will currently get rejected when find_package(libavif 0.8.2) is requested.

CMake Warning at CMakeLists.txt:5 (find_package):
  Could not find a configuration file for package "libavif" that is
  compatible with requested version "0.8.2".

  The following configuration files were considered but not accepted:

    C:/msys64/ucrt64/lib/cmake/libavif/libavif-config.cmake, version: 1.0.1

No problem w/ Autotools build as it grabs and compares version from pkg-config using simple >=...

@kmilos kmilos changed the title Support libavif 1.0 Support libavif 1.0 in CMake build Sep 6, 2023
@vapier vapier added the build label Sep 11, 2023
@vapier
Copy link
Member

vapier commented Sep 11, 2023

@morsssss fyi

@morsssss
Copy link
Contributor

Thanks for letting me know @vapier !

I admit I haven't worked with CMake since I worked on AVIF support here. If someone knows how to configure this properly, please do so. Otherwise I will get back into this when I get a spare hour or two...

@kmilos
Copy link
Author

kmilos commented Sep 14, 2023

You can take a look at some Arch patches for example (not for gd though as it builds w/ Autotools there, but e.g. darktable and kimageformats): https://archlinux.org/todo/libavif-10/

@nono303
Copy link

nono303 commented Nov 6, 2023

Hi,
Fyi, This simple patch does the trick for me: https://github.com/nono303/win-build-scripts/blob/81072312071b5b4b2feaf639f01100b4bf8f4dfc/modules/libgd.patch#L21 (cmake compile file & work fine on Win vs17 x64)

emaste added a commit to emaste/libgd that referenced this issue Feb 4, 2024
@emaste
Copy link

emaste commented Feb 4, 2024

Hi, Fyi, This simple patch does the trick for me: https://github.com/nono303/win-build-scripts/blob/81072312071b5b4b2feaf639f01100b4bf8f4dfc/modules/libgd.patch#L21 (cmake compile file & work fine on Win vs17 x64)

Thanks, with that patch I've been able to add CI for FreeBSD via Cirrus-CI: https://cirrus-ci.com/task/5194521131089920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants