Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont disable petsc just because mpi is disabled #2

Closed
wants to merge 1 commit into from

Conversation

lindsayad
Copy link
Member

closes #1

@roystgnr. Feel free to tag your disable petsc nemesis 馃槃

@lindsayad
Copy link
Member Author

@milljm can you apply this patch and see if this results in libmesh still using petsc?

@roystgnr
Copy link
Member

roystgnr commented Sep 4, 2020

Feel free to tag your disable petsc nemesis

I know, I was looking forward to poking fun at @benkirk for disabling this capability in a stealth commit, but I looked back further and it turns out that when I enabled it that was also via stealth commit, so there goes my moral high ground.

At least someone's using an actual PR this time, thank you.

Eventually we ought to actually try verifying whether our PETSc was built with MPI or in serial, so we can have --disable-mpi affect the former case but not the latter.

@milljm
Copy link

milljm commented Sep 4, 2020

That did not seem to do the trick...

  metaphysicl...................... : yes
  metis............................ : yes
  mpi.............................. : no
  nanoflann........................ : yes
  nemesis.......................... : no
  netcdf........................... : yes
     version....................... : 4
  nlopt............................ : no
  parmetis......................... : no
  petsc............................ : no
  qhull............................ : yes
  sfcurves......................... : no

Copy link
Member Author

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we still want to enable serial PETSc?

@roystgnr
Copy link
Member

roystgnr commented Dec 9, 2020

I still want serial PETSc re-enabled, sure, but "That did not seem to do the trick..." suggested that this PR wasn't doing it, no?

@lindsayad
Copy link
Member Author

I don't know if this is relevant any more

@lindsayad lindsayad closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't disable petsc just because mpi is disabled
3 participants