Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babelgene package to re-implement convertIdentifiers() #2

Open
lianos opened this issue May 6, 2021 · 0 comments
Open

Use babelgene package to re-implement convertIdentifiers() #2

lianos opened this issue May 6, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lianos
Copy link
Owner

lianos commented May 6, 2021

We previously included species and identifier maps in this package for this function to work, but since {babelgene} (which powers {msigdbr}) is now a dependency, let's use that.

Note the original function was called remap_identifiers, but since we're using camel case here, we're going with convertIdentifiers (and "converting" is more what we are doing, not remaping (I guess? ... who knows ...))

@lianos lianos added the enhancement New feature or request label May 6, 2021
@lianos lianos self-assigned this May 6, 2021
@lianos lianos changed the title Use babelgene package to re-implement remap_identifiers Use babelgene package to re-implement convertIdentifiers() May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant