Skip to content
This repository has been archived by the owner on May 8, 2018. It is now read-only.

Porting to Phaser 3 #57

Open
sebashwa opened this issue Apr 3, 2018 · 3 comments
Open

Porting to Phaser 3 #57

sebashwa opened this issue Apr 3, 2018 · 3 comments

Comments

@sebashwa
Copy link

sebashwa commented Apr 3, 2018

Hi @lewster32,

first of all thanks a lot for this awesome plugin!
I recently fell in love with isometric projection ❤️ and I want to create a game with Phaser 3. Therefore I started porting your plugin be compatible with Phaser 3 (which includes some breaking changes). I'm pretty new to Phaser and game development in general but I already got the basic projection part working (adding iso sprites to the scene). There is still some work left to do though (mainly the physics part and still some problems with the anchors of the isosprites - there are no more anchors in Phaser 3).

Now I'm wondering if it's OK for you, that I create a pull-request so maybe you can have a look at the code as well and as soon as it is finished it can be merged to this repository. Or if you'd prefer me to fork this repo so I can maintain the Phaser 3 version seperately.

I think I'd go for the first option and keep a tag of the current version, so it still can be used for Phaser 2. What do you think?

@lewster32
Copy link
Owner

Hi @sebashwa - sounds great! I would say that this repo should remain 2.x compatible, though I'm very open to pull requests to fix the numerous bugs that remain in the plug-in. From what I've seen of Phaser 3 so far, the architecture is quite different (flat display list etc.) which in many ways makes it better for isometric stuff. I'd say it'd be better for you to fork as I see the codebase being a significant departure also, though I'll happily redirect people to your repo as the place to go for iso in Phaser 3 :)

@sebashwa
Copy link
Author

sebashwa commented Apr 4, 2018

Sounds like valid reasons to keep this repo!
I forked your repo and the basic functionality seems to work already. I hope I can get to some further coding on this project in the coming days.
It would be awesome if you'd give people a hint to my repo. If you find some time I invite you to have a look at the code as well 😄 would be very much appreciated (i.e. I just deleted the sorting stuff from the Projector class because Phaser3 allows to set a depth value on Sprites which is used for depth sorting by Phaser internally. It seems to work fine so far but I'm really not sure if this is sufficient in all cases.. maybe you have an opinion on that)

Cheers

@lewster32
Copy link
Owner

Had a bit of a look through and it looks like you're doing splendid work. I'm much more comfortable with ES6 now and it all looks nice and clean - great stuff! I've thrown up a link to your repo in the readme and as your project matures I'll likely stick a link to it from the main website too. Thank you so much for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants