Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve <defs> #13

Open
leungwensen opened this issue Aug 5, 2016 · 2 comments
Open

resolve <defs> #13

leungwensen opened this issue Aug 5, 2016 · 2 comments
Labels
Milestone

Comments

@leungwensen
Copy link
Owner

complex SVG icons using <defs> (for reusing paths, enable gradients, etc.) can not be rendered properly if simply replace <svg> into <symbol>. <defs> should be placed just under root level.

@leungwensen leungwensen added the bug label Aug 5, 2016
@leungwensen
Copy link
Owner Author

leungwensen commented Aug 5, 2016

conclusion:

  • removing style="display:none;" in <svg> tag can solve this for webkit-based browsers;
  • extracting gradients should fix this problem for IE and Firefox.

@Tklaversma
Copy link

Tklaversma commented Aug 9, 2016

Besides that fact that you have a bug when not using <defs>, it is also not compliant to the SVG 1.1 spec, which states the use of <defs>.

Also see #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants