Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable window decorations only in fullscreen layout #52

Open
Gutsosan opened this issue Apr 28, 2024 · 3 comments
Open

Option to disable window decorations only in fullscreen layout #52

Gutsosan opened this issue Apr 28, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Gutsosan
Copy link

Gutsosan commented Apr 28, 2024

Hello, i just found out about your window tiling project and i couldn't be more happy and amazed.
You 've done an amazing job and it's exactly what i was looking for.

The only thing missing, as the titles says, is the option to disable window decorations only in fullscreen layout.

I am aware of the option to completely disable window decorations, but i'd like to keep it just for fullscreen windows.
I would not ask for this, just to satisfy my personal needs, but since you have a similar option already coded, i guess and i hope that it is not hard to include one more option for fullscreen only.

Thanks again for your great work!!

@leukipp leukipp self-assigned this May 3, 2024
@leukipp leukipp added question Further information is requested enhancement New feature or request labels May 3, 2024
@leukipp
Copy link
Owner

leukipp commented May 3, 2024

I want to keep this as general as possible, what about new layouts?

  • maximized: window maximized inside tiling area
    • with/without decoration, same as the current "fullscreen" mode, considering desktop margins
  • fullscreen: window fullscreen over screen
    • without decoration, ignoring desktop margins, overlaying panel bars

Would this satisfy your requirements?

@Gutsosan
Copy link
Author

Gutsosan commented May 8, 2024

I want to keep this as general as possible, what about new layouts?

  • maximized: window maximized inside tiling area

    • with/without decoration, same as the current "fullscreen" mode, considering desktop margins
  • fullscreen: window fullscreen over screen

    • without decoration, ignoring desktop margins, overlaying panel bars

Would this satisfy your requirements?

Sorry for the late reply.

Sure, those options sound great.

I have enabled the titleless_maximize option in xfce settings and use the top panel bar as window title with buttons and the appmenu, so that option would make my desktop feel the same as now with a great tiling manager on top, as yours is.

Your program is already great, but this addition would make it perfect for me if that doesnt put you into any unnecessary trouble.

Cheers and thanks again!

@Gutsosan
Copy link
Author

I noticed that when i remove window decorations, when i open a new window some empty bars appear on top or bottom of the window most of the times, at the size of the window title bar. I noticed that the problem doesnt appear by disabling the compositor (using xfce DE).
Maybe instead of making new layouts with disable/enable window decoration option, it would be better to make a new layout with maximized windows and take advantage of the DE's setting for titleless windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants