Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #456

Open
doppiogancio opened this issue Jul 13, 2022 · 2 comments
Open

Test coverage #456

doppiogancio opened this issue Jul 13, 2022 · 2 comments

Comments

@doppiogancio
Copy link

Hi, I just realized that tests are executed against an actual Jira endpoint and they are failing because, for example, I don't have an issue called TEST-155.

  1. Is this intended or did I wrongly configure the ENV file?
  2. I saw that some tests are 4-5 years old, could I collaborate and improve the test coverage?
@lesstif
Copy link
Owner

lesstif commented Jul 24, 2022

Hi @doppiogancio I'm sorry for the late reply.

you're a good point, Many test cases are hard coded in Unit tests, so it's not useful for most users.

  1. Many Issue Keys need set through Env files or run time argument.
  2. I always welcome user's PR :). so you can collaborate and improve all the test case!

@doppiogancio
Copy link
Author

Hi @lesstif, I tried different approaches and now I understand why (maybe) people are discouraged from testing: curl it's not easy to mock.

Having an HTTP client would be much easier to increase test coverage, but replacing curl everywhere won't be that easy and fast.

I will come back to you with a proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants