Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO - add format PME MiniDot function #141

Closed
leppott opened this issue May 24, 2022 · 6 comments
Closed

DO - add format PME MiniDot function #141

leppott opened this issue May 24, 2022 · 6 comments
Labels
enhancement high priority

Comments

@leppott
Copy link
Owner

leppott commented May 24, 2022 •
edited

Is your feature request related to a problem? Please describe.
Similar to formatHobo function add a function for data files from PME MiniDot

Describe the solution you'd like
see above

Describe alternatives you've considered
NA

Additional context
Have to edit files by hand.
User submission by email 2022-03-07

formatHobo() code is here:

https://github.com/leppott/ContDataQC/blob/main/R/formatHobo.R
@leppott
Copy link
Owner Author

leppott commented May 24, 2022

Manual

https://www.pme.com/wp-content/uploads/PME-miniDOT-Manual-2021.pdf

Example CAT.txt file after processing with miniDOTConcatentate java program.

image

@leppott
Copy link
Owner Author

leppott commented May 24, 2022

Code to compile the files if miniDOTConcatenate not used.

https://github.com/mnsentinellakes/mnsentinellakes/blob/master/R/compile_do_folder.R

@leppott leppott pinned this issue May 25, 2022
leppott added a commit that referenced this issue May 25, 2022
@leppott
v2.0.6.9021
c0ae4c2 
* feature: Add miniDOT concatenate function, Issue #141
    + Modified compile_do_folder.R from mnsentinellakes
@leppott
Copy link
Owner Author

leppott commented May 25, 2022

Concatenate function added as minidot_cat.

leppott added a commit that referenced this issue May 25, 2022
@leppott
v2.0.6.9022
5963298 
* refactor: Updates to minidot_cat function, Issue #141
* refactor: Add missing return value for help script line 937
leppott added a commit that referenced this issue May 25, 2022
@leppott
v2.0.6.9023
c0086a9 
-   refactor: Update minidot_cat function, Issue #141
    -   Remove filename parameter and use serial number from input file
-   feature: Add format minidot function, Issue #141
@leppott
Copy link
Owner Author

leppott commented May 31, 2022

minidot program adds DO Pct saturation column as NA if no inputs given for the calculation.

This causes ContDataQC() to crash (since all values NA).

Issue #143

@leppott
Copy link
Owner Author

leppott commented May 31, 2022 •
edited

6b1af4e

v2.0.6.9024

@leppott leppott closed this as completed May 31, 2022
leppott added a commit that referenced this issue Jun 7, 2022
@leppott
v2.0.6.9025
2a39ce6 
2022-06-07

-   fix: Modify config.R for salinity, Issue #138
    -   Update other copies in package
- feature: Begin adding miniDOT to shiny, Issue #141
leppott added a commit that referenced this issue Jun 15, 2022
@leppott
v2.0.6.9026
ff767fe 
feature: Add miniDOT functions to Shiny, Issue #141
@leppott
Copy link
Owner Author

leppott commented Jun 15, 2022

Shiny

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leppott