Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector length for each level is not the same #4

Open
leizhaocs opened this issue May 23, 2017 · 1 comment
Open

vector length for each level is not the same #4

leizhaocs opened this issue May 23, 2017 · 1 comment

Comments

@leizhaocs
Copy link

leizhaocs commented May 23, 2017

Hi, thank you for your implementation.

Based on my understanding of the paper, the length of the vector to each level in figure 1 of the paper should be the same. According to the paper "The estimated class distribution forms a class vector, which is then concatenated with the original feature vector to be input to the next level of cascade".

However, in your implementation, the input to the first level is 1520, the input to the second level is 1560, the input to the third level is 1600, etc.

If I misunderstood the paper, please kindly tell me.

Anyway, I fixed the code myself and find no significant difference in accuracy.

@leopiney
Copy link
Owner

Hi @shuzihua

You're definitely right. The paper is very clear explaining that part of the algorithm now that I see.
Even though there's no noteworthy difference in the results, feel free to collaborate on this repository!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants