Control-Click on Class Name May Return String Instance Instead Of Class Definition

[tbpassin]

When I CONTROL-Clicked Commands on this line:
c = leoCommands.Commands(fileName,

Leo navigated me to the following instead of the actual class definition:

    return {
        'ChapterCommandsClass': ['class ChapterController'],
        'EditCommandsClass': [
            'EditCommandsClass',
            'class Commands',
            'class LeoQtFrame',
            'class LeoBody',
        ],

IMHO, Leo should have navigated to the actual class definition line, not to the target in a quoted string. At a minimum, the target could be class Commands\s*[:(], but preferably there would be a check for surrounding quotations.

[edreamleo]

@tbpassin This issue is too minor and too tricky to fix in any useful way. I am going to close it.

Yes, the results may not be optimal, but executing find-next (F3) or find-prev should mostly work.

The code contains this comment: re searches are more accurate, but not enough to be worth changing the user's settings. Saving and restoring the users settings is what makes #3871 so fraught.

[edreamleo]

@tbpassin Aha! Don't ever change search settings. See #3871 for details.