Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VR3-style rendering overlaid on standard editing nodes. #3887

Open
tbpassin opened this issue Apr 25, 2024 · 3 comments
Open

Allow VR3-style rendering overlaid on standard editing nodes. #3887

tbpassin opened this issue Apr 25, 2024 · 3 comments
Assignees
Labels
Delegated Delegatated to others Enhancement
Milestone

Comments

@tbpassin
Copy link
Contributor

tbpassin commented Apr 25, 2024

This enhancement would allow Leo to optionally render non-text nodes in the same place as the current textual display. Some other software such as Trillium do this, but currently Leo can only render such nodes in a separate frame or tab, as the viewrendered and viewrendered3 plugins do.

One way to do this might be to have VR/VR3 render to a new target that overlays the text node frame rather to a separate frame as they currently do.

Another approach would be to have nodes display in a tabbed widget rather than an editing widget. If the users chooses to display a rendering, the tabbed widget would switch to the rendering tab.

With either approach we could reuse most of the existing VR/VR3 code. Note that VR3 can deal with multiple languages in a single node, which can provide a lot of flexibility.

The freewin plugin already does this kind of dual rendering in a limited way.

@tbpassin tbpassin added this to the 6.7.10 milestone Apr 25, 2024
@edreamleo edreamleo changed the title Allow VR/VR3-style rendering overlaid on standard editing nodes. Allow VR3-style rendering overlaid on standard editing nodes. Apr 29, 2024
@edreamleo edreamleo modified the milestones: 6.7.10, 6.7.9 Apr 29, 2024
@edreamleo
Copy link
Member

@tbpassin I have changed the title of this issue, assigned it to you, and given it the 6.7.9 milestone.

I shall be working on #3892, which now applies only to the VR plugin.

@edreamleo
Copy link
Member

@tbpassin I see no reason to create a plugin architecture for the VR/VR3 plugins at this time. We can discuss it later if you like.

@edreamleo
Copy link
Member

edreamleo commented Apr 29, 2024

@tbpassin Both the VR and VR3 plugins face a fundamental problem: the is no extra screen space! That's why using a separate window for the VR or VR3 panes is a reasonable thing to consider.

Without creating a separate window, the VR and VR3 plugins can only take space from the body, outline and log panes. It's straightforward to overlay any of these panes without using the nested splitter plugin.

I'll approve any PR you submit that changes only the VR3 plugin.

There's no rush. I've assigned this issue to 6.7.9 only to indicate that I'm willing to consider a PR now.

@edreamleo edreamleo added the Delegated Delegatated to others label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Delegated Delegatated to others Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants