Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Offer an option to disable "locked chapters" #3

Open
nicolas-arnold opened this issue Jul 8, 2018 · 4 comments
Open

Navigation: Offer an option to disable "locked chapters" #3

nicolas-arnold opened this issue Jul 8, 2018 · 4 comments

Comments

@nicolas-arnold
Copy link

Hey,

thanks for your work! I've read your thesis and now started to work through your tutorial. I got stuck at the "working in a team" where the branches should next be explained, but the link at the end of the chapter before did not work.

Then I tried to go back and forth, and then tried to reload.

First I had to replay the whole chapter (and wait for some animations, type some commands again). In the end the link was still broken. After reloading the site, I would have to redo the whole thing.

I think the easiest fix would be a menu, where you could disable the locking of the chapters. I will revisit, if I have an easy option to skip, maybe hidden in some menu, as I know your intention behind the locking.

@lennerd
Copy link
Owner

lennerd commented Aug 19, 2019

Thanks for your feedback! 🙂 And sorry for the inconvenience. There are indeed some similar bugs I was experiencing when coming to the last chapters. Especialy adding more complex commits and branches.

The current implementation of Git inside the client is quite broken. I plan to refactore the whole tutorial later this year using https://github.com/isomorphic-git/isomorphic-git. Hope this works out.

Will add a comment in this issue if there more info.

@nicolas-arnold
Copy link
Author

Looks pretty promising! Do you still plan to refactor? I really enjoyed this explanation so far, would be nice if it will make it to a stable version. :)

@lennerd
Copy link
Owner

lennerd commented Mar 7, 2020

Yes, I do. Still difficult to find time to work on it.

@nicolas-arnold
Copy link
Author

Great. Maybe now is the time :). If you're going to work on it, I am happy to test the new implementation (or parts of it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants