Skip to content
This repository has been archived by the owner on Nov 18, 2019. It is now read-only.

Incorrect Angular Dependency #67

Open
saurabh-jtg opened this issue Sep 12, 2017 · 0 comments
Open

Incorrect Angular Dependency #67

saurabh-jtg opened this issue Sep 12, 2017 · 0 comments

Comments

@saurabh-jtg
Copy link

The minimum angular version mentioned in bower.json is 1.3 while there are two usages of $timeout() (at https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L50 and https://github.com/legalthings/angular-signature/blob/master/src/signature.js#L92) with no params which causes error in angular < 1.4.

Either the dependency of angular or the usage of the function must be modified. I'll suggest to change the usage as it'll broaden the usability of package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant