Skip to content
This repository has been archived by the owner on Nov 18, 2019. It is now read-only.

onMouseup() outside the canvas isn't fired #44

Open
paolosanchi opened this issue Dec 1, 2016 · 5 comments · May be fixed by #66
Open

onMouseup() outside the canvas isn't fired #44

paolosanchi opened this issue Dec 1, 2016 · 5 comments · May be fixed by #66

Comments

@paolosanchi
Copy link

paolosanchi commented Dec 1, 2016

If you fire the onMouseup event outside the canvas the updateModel() isn't called so if you accept() the sign it could be empty or wrong..
I've fixed adding modifying the accept() like this:


$scope.accept = function () {

    $scope.dataurl = $scope.signaturePad.isEmpty() ? EMPTY_IMAGE : $scope.signaturePad.toDataURL();
    return {
        isEmpty: $scope.dataurl === EMPTY_IMAGE,
        dataUrl: $scope.dataurl
    };
};

@adrogon
Copy link

adrogon commented Sep 4, 2017

Hello @paolosanchi, please advise whether #66 fixes your issue or not.

@paolosanchi
Copy link
Author

paolosanchi commented Sep 28, 2017

No, I've updated to 1.0.3 and the issue is still there.
Perhaps I wasn't so clear.
See the attached animation as an explanation of the issue

issue

@adrogon
Copy link

adrogon commented Jan 26, 2018

You were very clear, #66 is an open PR so is not part of a release yet.
So, would you be able to test the PR and provide your feedback? Thank you.

@paolosanchi
Copy link
Author

oh, I tought it was merged. I checked your PR #66 and seems to work
Thanks

@adrogon
Copy link

adrogon commented Jan 26, 2018

Thank you for your feedback, hope it gets through 😏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants