Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Fix broken skinning test #370

Open
kanerogers opened this issue Sep 27, 2022 · 3 comments
Open

[Maintenance] Fix broken skinning test #370

kanerogers opened this issue Sep 27, 2022 · 3 comments
Labels
good-first-issue This is a good first issue!

Comments

@kanerogers
Copy link
Collaborator

kanerogers commented Sep 27, 2022

Background

The skinning test is currently broken! This has most likely been the case for some time.

Actual:
[
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0,
  0.0
]
Expected:
[
  0.99999994,
  -3.0733645e-8,
  1.1920929e-7,
  0.0,
  1.3969839e-8,
  0.9999999,
  -5.401671e-8,
  0.0,
  -2.9802322e-8,
  -6.146729e-8,
  1.0,
  0.0,
  0.0,
  0.0,
  0.0,
  1.0
]

However, skinning does actually work, so something is just wrong with the tests.

@kanerogers kanerogers added the good-first-issue This is a good first issue! label Sep 27, 2022
@itsrajatrai
Copy link

Hi, Can I contribute on this project ? I am new to the opensource.

@kanerogers
Copy link
Collaborator Author

Hi there, thanks so much for reaching out!

While I'd love to say "yes, dive right in!!" Hotham is a very complex project with a lot of moving parts. I think if you're someone who's looking to get involved in Open Source for the first time, we're probably not a good fit for you. ☹️

I highly recommend finding a library that you use regularly, and then finding bugs, or improving their tests! Even these small changes are an amazing way to get started - at least that's what worked for me.

Best of luck!

@itsrajatrai
Copy link

Thankyou ! for the feedback Kane. This would help me a lot. 👍🏼

@kanerogers kanerogers assigned kanerogers and unassigned kanerogers Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue This is a good first issue!
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants