Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to indicate multiple x and y facets in mode 2 #883

Open
leeoniya opened this issue Oct 24, 2023 · 0 comments
Open

make it possible to indicate multiple x and y facets in mode 2 #883

leeoniya opened this issue Oct 24, 2023 · 0 comments

Comments

@leeoniya
Copy link
Owner

for scale ranging, 2d objects like heatmap cells can have xMin xMax yMin yMax facets that should be used for finding scale range. currently only a single x and y facet is used, leading to clipping of data.

uPlot/src/uPlot.js

Lines 1323 to 1330 in 38f63de

// TODO: only handles, assumes and requires facets[0] / 'x' scale, and facets[1] / 'y' scale
let [ xFacet, yFacet ] = s.facets;
let xScaleKey = xFacet.scale;
let yScaleKey = yFacet.scale;
let [ xData, yData ] = data[i];
accScale(wipScales[xScaleKey], pendScales[xScaleKey], xFacet, xData, xFacet.sorted);
accScale(wipScales[yScaleKey], pendScales[yScaleKey], yFacet, yData, yFacet.sorted);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant