Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are released being cut? #191

Open
hhff opened this issue May 22, 2020 · 6 comments
Open

Where are released being cut? #191

hhff opened this issue May 22, 2020 · 6 comments

Comments

@hhff
Copy link

hhff commented May 22, 2020

Hi there!

Thanks so much for all the hard work on ledge. Can I ask, where are released being cut to?

The latest I can find on OPM is 2.1.2. How is everyone installing up to 2.3.0?

@pintsized
Copy link
Member

Hi, ah yes, we had been using luarocks and opm, but that habit appears to have broken down. You can download releases manually here: https://github.com/ledgetech/ledge/releases

But I will try to get opm and luarocks up and running again...

@hhff
Copy link
Author

hhff commented Jun 1, 2020

Thank you, @pintsized !

Is there any documentation on that process? I haven't installed a lua package from Git before :)

@pintsized
Copy link
Member

Really it's just about ensuring the contents of the lib directory are placed wherever your lua_package_path is, so that you can require("ledge") and it will find ledge.lua.

There was an old convention to use the Makefile, but I just checked and that looks broken too :/

In the wild, some kind of CI will checkout the repo at a tag and place the files in the lua_package_path, but of course this requires manual dependency management.

I will try and fix this up, I hadn't realised it had gotten so out of shape.

@hhff
Copy link
Author

hhff commented Jun 1, 2020

thank you @pintsized !

So I'll just have my dockerfile pull the repo from git, and move the files into the right place 👍

Appreciate it!

@hamishforbes
Copy link
Collaborator

That would work, you could also use the release tarball URL e.g. https://github.com/ledgetech/ledge/archive/v2.3.0.tar.gz

Should probably switch to GH Actions and use the release event to push to OPM/Luarocks ;) @pintsized

@hhff
Copy link
Author

hhff commented Jun 1, 2020

Awesome. Thanks both. Ledge is awesome. You're doing very cool work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants