Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not Customize storage_driver #172

Open
wmzy opened this issue Feb 8, 2018 · 0 comments
Open

Can not Customize storage_driver #172

wmzy opened this issue Feb 8, 2018 · 0 comments

Comments

@wmzy
Copy link

wmzy commented Feb 8, 2018

As the doc, connect should return a bool.
So the line
https://github.com/pintsized/ledge/blob/2474cab721dc300b1dbc6ba40121283ba44bea47/lib/ledge.lua#L228
should be replaced by return driver, nil;
And the bool new() on the doc should be change.

While I return nil(return nil for no max) on get_max_size method, here will throw an error(attempt to compare nil with number).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant