Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with not-yet-released Visual Studio 2019 version 16.5 Preview 2 #1067

Open
CaseyCarter opened this issue Dec 19, 2019 · 0 comments · May be fixed by #1068
Open

Issue with not-yet-released Visual Studio 2019 version 16.5 Preview 2 #1067

CaseyCarter opened this issue Dec 19, 2019 · 0 comments · May be fixed by #1068

Comments

@CaseyCarter
Copy link

MSVC will remove some transitive includes from STL headers in this release. After doing so, the autowiring build will fail and report that there is no runtime_error in namespace std when compiling line 447 of auto_signal.h. The fix is quite simple: this header now needs to include <stdexcept> directly.
CaseyCarter added a commit to CaseyCarter/autowiring that referenced this issue Dec 19, 2019
@CaseyCarter
Include <stdexcept> in autowiring/auto_signal.h
3dbf9ab 
... to use `std::runtime_error`.

Fixes leapmotion#1067.
@CaseyCarter CaseyCarter linked a pull request Dec 19, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include <stdexcept> in autowiring/auto_signal.h CaseyCarter/autowiring
1 participant
@CaseyCarter