Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phaser 3 #52

Open
lean opened this issue Oct 31, 2017 · 14 comments
Open

Phaser 3 #52

lean opened this issue Oct 31, 2017 · 14 comments

Comments

@lean
Copy link
Owner

lean commented Oct 31, 2017

I have create the branch 'phaser3' to start with the implementation of the new release of the library.
Does anyone have any ideas or suggestions to implement?
Any functionality to add or remove?

There are some ideas:

  • implement an scaffolding tool like Yeoman
  • more documentation
  • create some common components or utilities
@RenaudRohlinger
Copy link
Contributor

  • Implement Phaser Manifest Loader for Webpack which provides an easy way to load assets : https://github.com/mattcolman/phaser-manifest-loader
    (+ it is based on this repo so it easy to implement)

  • Create a folder with a file implementing the main webpack config and extend it to a dev/prod/cordova... like that if you wants to add a plugin to your webpack config you don't have to copy/paste the same lines in every environnement (webpack.conf, webpack.deploy) <-- I could do that

@Raagh
Copy link

Raagh commented Dec 13, 2017

it would be nice if you could add support for electron. that way you d have mobile desktop and web on the same template :)

@rafaeldelboni
Copy link

What you think about add something like https://github.com/mixtur/webpack-spritesmith, then we could easily merge all the image assets into a atlas on the build (and in dev runtime).
I'm playing with this idea in a old fork of your repo, if you want to check it out:
https://github.com/RafaelDelboni/phaser-dungeon

@thisredone
Copy link

Maybe it's possible to add Webpack's Hot Module Replacement ( https://webpack.js.org/concepts/hot-module-replacement/ )

@oronbz
Copy link

oronbz commented Sep 6, 2018

Hi, I think we need to separate the upgrade to phaser 3 from the other enhancements, that way we could consume it in smaller chunks.

I'll try to upgrade it to phaser 3 and make a pull request for it.
Are you still up to merge it? @lean

EDIT: After looking through the phaser3 branch, I've seen it's mostly complete regarding upgrading to phaser3, is there anything missing that prevents you from merging to master?

@lean
Copy link
Owner Author

lean commented Sep 6, 2018

Don't worry about the merge, I will do manually because I was planning to move the v2 to another repo. So let me check your work and I will integrate it with what I have been doing

@rafaeldelboni
Copy link

I've made something very similar some time ago, maybe it helps as source of inspiration:
https://github.com/rafaeldelboni/phaser3-es6-webpack4

@oronbz
Copy link

oronbz commented Sep 6, 2018

@lean I'm not worried. I just don't want to repeat / duplicate work that already has been done. Is there anything else needed to be done on top of your phaser3 branch in order to support Phaser 3.0?

@lean
Copy link
Owner Author

lean commented Sep 6, 2018

@oronbz cool, let me update some things. I will tell you when I'm ready

@lean
Copy link
Owner Author

lean commented Sep 6, 2018

@rafaeldelboni thanks for share your project. I'm looking at it right now

@lean
Copy link
Owner Author

lean commented Sep 6, 2018

@oronbz I just updated https://github.com/lean/phaser-es6-webpack/tree/phaser3
Now is running with webpack 4 and babel 7

@oronbz
Copy link

oronbz commented Sep 7, 2018

@lean that's awesome, Is there any reason you haven't included cordova too?

@lean
Copy link
Owner Author

lean commented Sep 7, 2018

I haven't include for lack of time. I even think it's still incomplete. We need to add:

  • webpack config for production
  • cordova support

@jay-jlm
Copy link

jay-jlm commented Sep 12, 2018

For newcomers like me it would be useful to update the ReadME with some information about the v3 branch and any steps needed to use it (if any).
Some ppl will just assume there's no v3 support yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants