Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Production Ready and Contribute back to Spring Session? #1

Open
rwinch opened this issue Feb 10, 2016 · 4 comments
Open

Make Production Ready and Contribute back to Spring Session? #1

rwinch opened this issue Feb 10, 2016 · 4 comments

Comments

@rwinch
Copy link

rwinch commented Feb 10, 2016

Hey it has been a while since we last talked! I stumbled upon this project and was wondering if you were still interested in contributing this back to Spring Session?

@ldoguin
Copy link
Owner

ldoguin commented Feb 11, 2016

Yes absolutely. Got side tracked by lots of other things. From what I remember there was some work to do on the event part. Creating a phantom doc holding the TTL so that we could actually sent the document to be deleted in the appropriate event.
And I am sure there are other things to do :)

@rwinch
Copy link
Author

rwinch commented Feb 11, 2016

@ldoguin Thanks for the fast response!

One thing to note is that we can always start with an implementation that does not support events. The events are not required by the API and not everyone wants or needs the events anyways.

@ldoguin
Copy link
Owner

ldoguin commented Feb 11, 2016

@rwinch Actually the event part is already splitted and lives under spring-session-couchbase-listener.

@rwinch
Copy link
Author

rwinch commented Feb 11, 2016

@ldoguin Thats great news! Do you think you can start exploring getting this into a branch of Spring Session? I went ahead and created spring-projects/spring-session#363 for tracking this from the Spring Session side

Things we typically look for when getting a new datastore (looks like this is already pretty close):

  • Code (obviously)
  • Unit tests
  • Integration tests (fewer than the unit tests for speed but still ensure things are working)
  • Hello World Sample / Guide for Web Application (i.e. HttpSession Sample)
  • Sample Tests
  • Optional @EnableCouchbaseHttpSession for making things easier
  • Optional spring-session-couchbase pom that aggregates the dependencies to make dependency management for users easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants