Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input handling guardrails and glob expansion #133

Open
acesnik opened this issue Apr 30, 2024 · 2 comments
Open

Input handling guardrails and glob expansion #133

acesnik opened this issue Apr 30, 2024 · 2 comments

Comments

@acesnik
Copy link

acesnik commented Apr 30, 2024

Hi there, this is an exciting tool; thanks for making it!

Here are a couple of minor requests on input handling:

  1. It could be nice to check for file existence prior to generating the fragment index. One has to wait for that process to finish to find out the mzML doesn't exist in the current directory, for example.
  1. Performing glob::glob expansion of asterisks in the mzML list could make a little improvement in CLI experience
@acesnik acesnik changed the title Input handling guardrails Input handling guardrails and glob expansion Apr 30, 2024
@lazear
Copy link
Owner

lazear commented Apr 30, 2024

  • This is actually desired behavior on my end. Crashing or exiting because files don't exist or are corrupted is annoying if you are running a big search (e.g. failing on file 900 out of 1000)
  • This would be a nice feature (for windows users, since *nix shells will handle globbing automatically if specified via CLI) - would also be great to enable glob usage for S3 (via list-objects-v2 API). Are you interested in contributing a PR for this feature?

I would note that I also strongly recommend running sage via WSL if you're on windows... performance is definitely worse on Windows

@acesnik
Copy link
Author

acesnik commented Apr 30, 2024

Ah, sounds good!

  • How about creating a warning for file existence early in the run instead of erroring out?
  • I drafted up a glob feature PR (untested)
  • Interesting about the performance on Windows! I'll definitely keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants