Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS style rule updates for issue #5516 #5526

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JonathanKoerber
Copy link

@JonathanKoerber JonathanKoerber commented May 8, 2024

The SistentWrappre page section added margin-top: 15 to extend the container up. The margin-top in h2 and h3 was changed from -7 to 7, bringing text back inside the parent container and aligning the infra-page component with the top section.

JoinCommunityWrapper width 18rem => 25rem to match the current website. g

Description

This PR fixes #5516

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented May 8, 2024

🚀 Preview for commit 2d2ef1a at: https://663ba19250d9050e48a1cde8--layer5.netlify.app

@leecalcote leecalcote requested a review from lakshz May 10, 2024 03:04
@leecalcote
Copy link
Member

Thank you, @JonathanKoerber 👏

Copy link
Contributor

@lakshz lakshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-10 at 10 37 34

Unwanted margins on other sistent pages. Please fix @Jonathan-Foo

The ss is from guidance page of color

@lakshz
Copy link
Contributor

lakshz commented May 10, 2024

Screenshot 2024-05-10 at 10 46 17

When I click "About Sistent", I see the above page. It still doesn't scroll to the heading. The problem might be due to different screen sizes.

@ritiksaxena124
Copy link
Contributor

Hey @JonathanKoerber , let's discuss this on today's website meeting at 12:00 pm GMT / 5:30 PM IST. I am adding this as an agenda item. Please join if you are available during the meet.

@JonathanKoerber
Copy link
Author

Thanks for the feedback. I'll take another look at this issue.

@iArchitSharma
Copy link
Contributor

@JonathanKoerber thanks, let us know when you fix this

@captain-Akshay
Copy link
Contributor

captain-Akshay commented May 20, 2024

Screencast.from.2024-05-20.18-49-34.webm

Can you work on this much unnecessary white space

@JonathanKoerber
Copy link
Author

I'll work on the white space issue. Thanks for the feedback.

@l5io
Copy link
Contributor

l5io commented May 23, 2024

🚀 Preview for commit b6d3406 at: https://664fd71eaf6b27a2792c7a3a--layer5.netlify.app

@sudhanshutech
Copy link
Member

@JonathanKoerber merge conflicts...

…sed win identiy section page

Signed-off-by: JonathanKoerber <jonathankoerber@gmail.com>
@JonathanKoerber
Copy link
Author

Refactor About page to follow pattern of project/sistent/identiy/color. About now uses style from SystenLayout to style and and IntraPage component to generate links on right side from section title id's. Because there is not much content in about page no links will show. See the test link screen shot.
image
Image with Test link:
image
Mobile No extra white space:
image

@l5io
Copy link
Contributor

l5io commented May 27, 2024

🚀 Preview for commit a9d5b96 at: https://6653d4bb4b92a6fe2f91a1a9--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Sistent] Fix the positioning of page section navigator and working
9 participants