-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sistent] Fix the positioning of page section navigator and working #5516
Labels
Comments
ritiksaxena124
added
kind/enhancement
New feature or request
good first issue
Good for newcomers
labels
May 2, 2024
Hi, looking for my first issue could I work of this? |
I forked the repo and think that I have found the component that is causing the issue. in src/component/handbook-navigation/intra-page.js. The current css rule .infra-page upon initial inspection seems to be causing the issue. If assigned I'd like figure out if all the places where the components. The update the rule. |
Go ahead @JonathanKoerber 👍 |
JonathanKoerber
added a commit
to JonathanKoerber/layer5
that referenced
this issue
May 8, 2024
The SistentWrappre page section added margin-top: 15 to extend the container up. The margin-top in h2 and h3 was changed from -7 to 7, bringing text back inside the parent container and aligning the infra-page component with the top section. JoinCommunityWrapper width 18rem => 25rem to match the current website. x Signed-off-by: JonathanKoerber <jonathankoerber@gmail.com>
1 task
JonathanKoerber
added a commit
to JonathanKoerber/layer5
that referenced
this issue
May 23, 2024
…e with first line of p layer5io#5516
JonathanKoerber
added a commit
to JonathanKoerber/layer5
that referenced
this issue
May 23, 2024
The SistentWrappre page section added margin-top: 15 to extend the container up. The margin-top in h2 and h3 was changed from -7 to 7, bringing text back inside the parent container and aligning the infra-page component with the top section. JoinCommunityWrapper width 18rem => 25rem to match the current website. x Signed-off-by: JonathanKoerber <jonathankoerber@gmail.com>
JonathanKoerber
added a commit
to JonathanKoerber/layer5
that referenced
this issue
May 23, 2024
…e with first line of p layer5io#5516 Signed-off-by: JonathanKoerber <jonathankoerber@gmail.com>
JonathanKoerber
added a commit
to JonathanKoerber/layer5
that referenced
this issue
May 24, 2024
…e with first line of p layer5io#5516 Signed-off-by: JonathanKoerber <jonathankoerber@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
The position of the page section navigator is at the bottom and not working as expected on About page of Sistent.
Desired Behavior
Change the position from bottom to top and on click it should scroll to the heading and not to the middle part of the section.
Contributor Resources
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
master
branch.The text was updated successfully, but these errors were encountered: