-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sistent] Missing instructions related to the NPM packages and their use #5486
Comments
Hi, I'm interested in this issue. Could you please assign this to me? |
Excellent, @KunyueXing. Sounds great. Here is a recent description and details that will help - https://discuss.layer5.io/t/what-exactly-is-this-sistent-design-system-project/4934 |
@lakshz FYI |
@leecalcote Thanks for the reference. I'm starting working on this and will keep you updated. |
Hi, Lee @leecalcote . I found this website - https://www.npmjs.com/package/@layer5/sistent?activeTab=readme Is this the place where the Sistent's NPM packages are? |
Yes. Lakshay, please assist as needed. |
Some updates. Since I'm completely new to this community and front-end development, here's some homework that I did:
From my understanding, Sistent uses MUI v5 components, so I researched on how to incorporate the NPM packages of MUI v5, hoping it would give me some insights on Sistent because I think they may have some similarities. Here's what I found:
From the NPM registry of Sistent, I found this command to install the package.
@leecalcote and @lakshz, about this task, specifically "instructions on where the NPM packages are or how to incorporate their use", could you please provide some clarification? Is it about installation of Sistent, which is the NPM command above? |
@KunyueXing You are somewhat in the right direction, I believe. The command Your task is to write instructions to allow other contributors to use this package. Starting from installing the package to importing its components. The instructions would be something like this:
Above is just an overview of instructions to help you. The actual instructions can be more detailed and better. PS: You can look |
@lakshz Thank you for all the details! I'll keep investigating. |
@KunyueXing, |
Here's my updates, I used
I thought the task is to document how to import and use a certain component, similar to the doc of
My questions so far:
The usages of |
Hi @vishalvivekm, I'm not able to join the meeting since I'm in Pacific Time, which would be 5 am here. Can we reschedule the meeting to 8 pm PDT, or some other time? |
Hi @lakshz, could you please respond to my comment? |
For component-specific variants, there is a dedicated https://layer5.io/projects/sistent/components page. You may take one component and show it as an example. (not emphasizing on its variants) So, to summarize:
All of this needs to added under I hope this clears everything. I would request you to please create a PR and we can discuss further there, based on what is implemented. |
Sounds good, I'll work on the PR. |
I'm making slow progress due to family emergency for the past 2 weeks. I'm hoping to post the PR by the end of next week. |
I just created a pull request. @leecalcote @lakshz Who will be my reviewers? |
Great! @nebula-aac will be a reviewer. |
Current Behavior
Consumers (users) of the Sistent components are not offered instructions on where the NPM packages are or how to incorporate their use.
https://layer5.io/projects/sistent/about
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
master
branch.📚 See contributing instructions.
🎨 Wireframes and designs for Layer5 site in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack.
Join the Layer5 Community by submitting your community member form.
The text was updated successfully, but these errors were encountered: