Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to select "HDR" as a quality option #97

Open
jordyvandomselaar opened this issue Mar 17, 2021 · 9 comments · May be fixed by #212
Open

Possibility to select "HDR" as a quality option #97

jordyvandomselaar opened this issue Mar 17, 2021 · 9 comments · May be fixed by #212

Comments

@jordyvandomselaar
Copy link

Original discussion: #96

It would be really cool if it was possible to select "HDR" as a quality preset. Right now it is possible to select ultra-hd which selects 4k content but it does not select 4k HDR content.

Because of this I have to use the manual search every time I'd like to get HDR content.

Thanks in advance!

@lardbit
Copy link
Owner

lardbit commented Mar 17, 2021

Thanks for creating this issue. Can you tell me which specific tags you look for when trying to get "4k hdr"? These quality labels aren't totally clear to me. Do you think "RAW HD" is synonymous with "4k HDR"?

@lardbit
Copy link
Owner

lardbit commented Mar 17, 2021

I think my confusion is that "HDR" is not a quality per se. 720p, 1020p, etc are qualities. nefarious groups qualities and sources (i.e bluray, webrip) into quality "profiles". I'm trying to wrap my head around how to best integrate "HDR". If you have any ideas, please send them along.

@jordyvandomselaar
Copy link
Author

As far as I can see it's usually in the name. HDR is not really a quality profile because any resolution can also have HDR. I think it's more of an additional setting on top of quality.

@lardbit
Copy link
Owner

lardbit commented Mar 19, 2021 via email

@jordyvandomselaar
Copy link
Author

That would be awesome =)

@lardbit
Copy link
Owner

lardbit commented Mar 19, 2021

Alright, I'm sold on the idea. I'll keep this issue open until I have some time to tackle it, but my current idea is to keep the existing profiles but then include checkboxes for "modifiers". The radarr projects uses these but I don't really understand all of them and will at least include "HDR":

  • REGIONAL
  • SCREENER
  • RAWHD
  • BRDISK
  • REMUX

@Clickbaitcake
Copy link
Contributor

Alright, I'm sold on the idea. I'll keep this issue open until I have some time to tackle it, but my current idea is to keep the existing profiles but then include checkboxes for "modifiers". The radarr projects uses these but I don't really understand all of them and will at least include "HDR":

  • REGIONAL
  • SCREENER
  • RAWHD
  • BRDISK
  • REMUX

This Wiki explains them pretty well: https://en.wikipedia.org/wiki/Pirated_movie_release_types

@lardbit
Copy link
Owner

lardbit commented Jan 1, 2022

Thanks @Clickbaitcake, that's definitely helpful. I plan on downloading sonarr at some point to mirror some of it's quality profile logic when I'm ready to tackle this.

@lee-b
Copy link

lee-b commented Jul 26, 2022

I think HDR is a value of a color-space property, in the same way that 1080 is a value of a vertical-resolution property.

So 1080p should inform the vertical-resolution and refresh-rate properties, and HDR should inform the colour-space property.

Then there is the bit-rate property, the remuxed property, the source (cam, hdr, etc.), and subtitle-language and audio-language properties.

None of these alone tell you the overall quality, but that could be calculated by combining the different properties.

@lardbit lardbit linked a pull request Aug 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants