Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer script syncing #31

Open
pirog opened this issue Apr 9, 2024 · 1 comment
Open

Windows installer script syncing #31

pirog opened this issue Apr 9, 2024 · 1 comment
Assignees
Labels
flag Flag an issue for discussion in relevant contrib meeting

Comments

@pirog
Copy link
Sponsor Member

pirog commented Apr 9, 2024

when #17 is merged we should consider a few things to better align it with the POSIX version, that includes:

  • downloading the slim CLI by default for better performance
  • using lando shellenv to set up PATH things
  • running lando update
  • switching from mklink to using a "wrapper" script as in https://github.com/lando/core/blob/main/utils/get-winbin-contents.js
  • standardize option conventions eg on POSIX its --no-setup and on PS its -no_setup eg hypens or underscores? We generally use hyphens on stuff so my preference would be changing the PS one to match the larger convention. or is there some restriction on PS that prevents hyphens being used for options?
@pirog pirog added the flag Flag an issue for discussion in relevant contrib meeting label Apr 9, 2024
@pirog
Copy link
Sponsor Member Author

pirog commented Apr 22, 2024

@AaronFeledy added some extra stuff in OP we might want to consider now that #16 #17 is completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag Flag an issue for discussion in relevant contrib meeting
Projects
Status: Ready
Development

No branches or pull requests

2 participants