Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove recursive-ascent, LALR support for 1.0, and other non-recommended modes #759

Open
nikomatsakis opened this issue Apr 22, 2023 · 0 comments
Open

remove recursive-ascent, LALR support for 1.0, and other non-recommended modes #759

nikomatsakis opened this issue Apr 22, 2023 · 0 comments
Milestone
1.0

Comments

@nikomatsakis
Copy link
Collaborator

LALRPOP has a lot of modes. I propose we remove some of them for 1.0 and simplify our lives. For example:

  • Remove recursive ascent. Generates too much code. Probably more performant, but I'm not aware of anyone who cares. Maybe we can search github or crates.io to see.
  • Remove LALR support. The lane table algorithm is fine.
  • Remove the option to generate code into the src directory and only support the lalrpop_mod approach.

Thoughts @lalrpop/maintainers ?
@nikomatsakis nikomatsakis added this to the 1.0 milestone Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@nikomatsakis