VLAN tag strip out stop data plane fowarding at Edge port with FAUCET

[mbruyere]

Issue Type

• Bug report
• Feature proposal

Summary

The problem is that FAUCET will push a VLAN header on a packet, then pop it.
In the meantime, we need to match on the packet's VLAN header after the push but before the pop.
It appears it will not match the packet when the header has been pushed.

Bug report

Vlan pop out functions at the Edge port break the matching or forwarding action.

Here is the lagopus show flow output even with the counter at zero.

         "table": 7,
                "flows": [
                    {
                        "priority": 9008,
                        "idle_timeout": 0,
                        "hard_timeout": 0,
                        "cookie": 1524372928,
                        "in_port": 1,
                        "dl_dst": "ff:ff:ff:ff:ff:ff",
                        "vlan_vid": "4196",
                        "actions": [
                            {
                                "apply_actions": [
                                    {
                                        "strip_vlan": null
                                    },
                                    {
                                        "output": 2
                                    }
                                ]
                            }
                        ],
                        "stats": {
                            "packet_count": 0,
                            "byte_count": 0
                        }
                    },

Expected behavior

Packets with VLAN tag strip out at the edge should not break the data plane.

Actual behavior

Trying to ping two hosts connected to Lagopus does not work using native VLAN at the Edge and VLAN tagging in the Lagopus bridge.
If we configure the hosts with trunks and lagopus does not have to strip out the VLAN tag it works.

Environment

Steps to reproduce

Relevant logs

All details can be found in the linked file below :
FAUCET LAGOPUS confs .txt

Links / reference

[ynkjm]

Thank you for report.
Could you share your flow entries that include VLAN push and pop (strip)?

[mbruyere]

here is :
FAUCET Lagopus show flow output.txt

[ynkjm]

Thanks!

[hirokazutakahashi]

I've merged the fix for this issue to the master branch. Please test it.