Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding of ServiceRouter's exception logging #1091

Open
steve-scx opened this issue Nov 6, 2017 · 2 comments · May be fixed by #2251
Open

Allow overriding of ServiceRouter's exception logging #1091

steve-scx opened this issue Nov 6, 2017 · 2 comments · May be fixed by #2251
Labels
topic:service-api type:feature

Comments

@steve-scx
Copy link

It would be useful to be able to override the ServiceRouter's exception logging. Would also be useful to provide the override with access to the request header. This would allow the customized log event to include request context for tracing, etc...

It seems that this is not currently supported, as of Lagom 1.3.8.

Not super familiar with the Lagom code, but it looks to me like moving ServiceRouter's logException to LagomServiceApiBridge (and passing the request header) and then working through that customization might be a reasonable approach.

Thoughts?
@ignasi35
Copy link
Contributor

ignasi35 commented Nov 7, 2017

related to https://groups.google.com/d/msgid/lagom-framework/8fbd0f26-61bf-4ee6-8f73-96b25d75d94f%40googlegroups.com?utm_medium=email&utm_source=footer

@TimMoore TimMoore mentioned this issue Jun 26, 2018
Open
@TimMoore
Copy link
Contributor

Related (possible duplicate): #1307

@yakovlevdmv yakovlevdmv linked a pull request Sep 9, 2019 that will close this issue
Open
8 tasks
@ihostage ihostage mentioned this issue Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:service-api type:feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Implement ServiceCall exception logging using HttpErrorHandler interface yakovlevdmv/lagom
4 participants
@TimMoore @dwijnand @ignasi35 @steve-scx