Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible Linting #238

Open
willifehler opened this issue Mar 28, 2024 · 0 comments
Open

Ansible Linting #238

willifehler opened this issue Mar 28, 2024 · 0 comments

Comments

@willifehler
Copy link

willifehler commented Mar 28, 2024

Hi there,

thank you so much for this wonderful role. Please keep it going.

I have a feature request:
It would make sense to use ansible and yaml linting.

Just an example. It would make sense to use the fqcn here. (ansible.builtin.copy)

- name: Configure datacenter.cfg
  copy:
    dest: "/etc/pve/datacenter.cfg"
    owner: "root"
    group: "www-data"
    mode: "0640"
    content: |
      {% for k,v in pve_datacenter_cfg.items() %}
      {{ k }}: {{ v }}
      {% endfor %}
  when:
    - "not pve_cluster_enabled | bool or (pve_cluster_enabled | bool and inventory_hostname == _init_node)"
    - "pve_datacenter_cfg | length > 0"

Cheers - Willi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant