Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize vg.shape.check so locals() does not need to be passed in #70

Open
paulmelnikow opened this issue Sep 20, 2019 · 0 comments
Open

Comments

@paulmelnikow
Copy link
Member

paulmelnikow commented Sep 20, 2019

The call to locals() makes vg.shape.check() much slower than it needs to be in the (very likely) success case. As an optimization, as a convenience to the caller, we could modify it to fetch locals from the stack rather than requiring the caller to pass them in.

See this comment thread which explains the approach: lace/blmath#17 (comment)

@paulmelnikow paulmelnikow changed the title Consider modifications to vg.shape.check Optimize vg.shape.check so locals() does not need to be passed in Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant