Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support function and parlamentarian surname, Nationalrat XY #6

Open
scito opened this issue Oct 12, 2019 · 3 comments
Open

Support function and parlamentarian surname, Nationalrat XY #6

scito opened this issue Oct 12, 2019 · 3 comments

Comments

@scito
Copy link

scito commented Oct 12, 2019

GLP-Parteipräsident Grossen is not recognized, only standard full name "Jürg Grossen".
https://www.beobachter.ch/umwelt/umfrage-fdp-wahler-fliegen-am-haufigsten

I suggest to define and support name patterns

[function] [surname]
[party]-[function] [surname]

E.g.
Nationalrat Grossen
Nationalrätin [surname]
[Party]-Parteipräsident [surname]
Ständerat Berberat

Some patterns may depend on newspaper style. E.g. boulevard news papers as blick.ch may use more informal patterns or even nicknames.
It could also be an option to extend the lobbywatch datamodel with nicknames.

This is a nice to have enhancement for future versions.

@palrogg
Copy link
Contributor

palrogg commented Oct 13, 2019

Good idea!
There's already a regexp pattern:
new RegExp('([^"])' + name);

We could edit it in the German version, something such as:
new RegExp('([^"])(Nationalr[aä]t|Parteipräsident|Ständer[aä]t)(in){0,1}' + surname | name);

I just need a good surname list either with Lobbywatch API or with the Parliament Webservice.

In German, you always write “Nationalrat de Courten” / “Nationalrat de Buman”, right? And not “Nationalrat Courten”?

Best
Paul

@scito
Copy link
Author

scito commented Oct 14, 2019

In German, you always write “Nationalrat de Courten” / “Nationalrat de Buman”, right? And not “Nationalrat Courten”?

I would say yes, Nationalrat de Courten since de Courten is the name.
Nationalrat Courten sounds weird in my ears.
But there is certainly no rule without exception.

We could edit it in the German version, something such as:
new RegExp('([^"])(Nationalr[aä]t|Parteipräsident|Ständer[aä]t)(in){0,1}' + surname | name);

Good idea

Maybe it is better to split this issue.
The surname is more complicated. We have to change the datamodel, insert the data and change all the interfaces up to the Addon.

These surnames is an idea of me. We have to check if these surnames are really used in newspapers. I'll ask the others in Slack.

@scito
Copy link
Author

scito commented Oct 14, 2019

Another case could be only party or official functions without any name.

For a given time, FDP-Präsidentin oder SP-Fraktionspräsident are sufficient to identify the correct persons.
Or Nationalratspräsidentin

Now,
FDP-Präsidentin = Petra Gössi
SP-Fraktionspräsident = Roger Nordmann
Nationalratspräsidentin = Marina Carobbio Guscetti

But the time of the publication has to be taken into account. Page meta data such as creation date could be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants