udisks2: Be more tolerant of device-startup time #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a3f Could you take a look at this? |
a3f
suggested changes
Apr 24, 2024
When switching an SDWire to 'host' mode, it may take time for the partition to appear. During that time the device (e.g. '/dev/sdo1') may not exist, so trying to cat e.g. '/sys/call/block/sdo1' fails. Handle this by returning a zero size in that case, as is done when the returned size is empty. Even when the block device is present, udisks2 may take a short time to make the device available. Handle this by retrying a few times, until things settle. Add the call to _wait_for_medium() in write_files() while we are here, to match what is done in write_image(). Also fix the parameter type for write_files() and mention the exception it may raise. Fixes: labgrid-project#1357 Signed-off-by: Simon Glass <sjg@chromium.org>
OK, I addressed one and explained the other |
Emantor
previously approved these changes
May 2, 2024
There was a problem hiding this comment.
@Emantor Please don't merge this, yet. I'd like to look into this. I suspect the retry mechanism can be implemented more straight forward.
Any word on when you will figure this out? I am able to test things if it helps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching an SDWire to 'host' mode, it may take time for the partition to appear.
During that time the device (e.g. '/dev/sdo1') may not exist, so trying to cat e.g. '/sys/call/block/sdo1' fails. Handle this by returning a zero size in that case, as is done when the returned size is empty.
Even when the block device is present, udisks2 may take a short time to make the device available. Handle this by retrying a few times, until things settle.
Add the call to _wait_for_medium() in write_files() while we are here, to match what is done in write_image(). Also fix the parameter type for write_files() and mention the exception it may raise.
This change has been manually tested since there are no tests available for the code being modified.
Checklist
(I cannot find any tests for USBStorage)
(not needed, I think)
--->
(it seems that these were out-of-sync before my PR)
Fixes: #1357