Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

groups similar methods/classes #315

Open
erickvermot opened this issue Mar 20, 2017 · 1 comment
Open

groups similar methods/classes #315

erickvermot opened this issue Mar 20, 2017 · 1 comment

Comments

@erickvermot
Copy link
Contributor

erickvermot commented Mar 20, 2017

Group similarities as in HWAdress and DPID.
The have very similar pack functions for example.
Maybe should they be derived from a same base class ("colon separated hex
values...")
Same with echo request, echo reply, and hello... and many others..

Maybe implement using Mixin classes, as proposed by Diego. I agree;

@beraldoleal
Copy link
Member

I Agree. Definitely this need a refactoring. There is a few duplicated code there.

For instance _fmt is not being used in some cases. But lets discuss this on future refactoring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants