Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we rename namespaces to lowercase? #97

Open
odinthenerd opened this issue Dec 5, 2016 · 2 comments
Open

Should we rename namespaces to lowercase? #97

odinthenerd opened this issue Dec 5, 2016 · 2 comments
Labels

Comments

@odinthenerd
Copy link
Member

In the interest of breaking things now rather than later it seems people don't like my style ;) basically types being UpperCamelCase and values and functions being lowerCamelCase is ok by most people but that fact that namespaces are also upper camel case bugs a lot of people. So we should probably change it.

The one breach in this style is the nested type in Metafunction::type. The problem is that TMP convention is to use lower case type but it is a type so according to this style guide it should be upper case. I think we can get away with this breach in our style guide and use lower case though because the user should never see this, its just library internals.

@TorstenRobitzki
Copy link

As I wrote a lot of ruby code, I could live with your style, but for consistency with existing C++ code, I would prefer the usual C++ style (all lower, underscores, template parameters in camle case etc.)

@TorstenRobitzki
Copy link

TorstenRobitzki commented Dec 18, 2016

In addition, I would suggest to put all headers under one "kvasir" directory just to reduced the risk that a path or file name clashes with other parts of a project. Using lower case file and path names would be more consistent too (Lib/, test/, Tools/, doc/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants