Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lens): add get/set lenses [WIP] #36

Closed
wants to merge 1 commit into from
Closed

feat(lens): add get/set lenses [WIP] #36

wants to merge 1 commit into from

Conversation

bangn
Copy link
Contributor

@bangn bangn commented Oct 19, 2020 •
edited by kutyel

Modified get/set in function.js so lens works with Map.

It is WIP and played as a discussion point.

As the result, the coverage is not yet reach 100%. Will fix it after we have
agreed on the approach :)

Fixes #29

@kutyel kutyel requested a review from serras October 19, 2020 11:38
@serras
Copy link
Collaborator

serras commented Oct 21, 2020

No, this approach is not the one we want to follow. Instead, the idea is to create another lens creator (which does not use get and set) which called the get and set methods on the underlying objects.

@kutyel kutyel closed this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serras serras Awaiting requested review from serras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get/set lenses (for Immutable.js, among others)
3 participants
@bangn @serras @kutyel