Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get/set lenses (for Immutable.js, among others) #29

Open
serras opened this issue Sep 30, 2020 · 3 comments
Open

get/set lenses (for Immutable.js, among others) #29

serras opened this issue Sep 30, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@serras
Copy link
Collaborator

serras commented Sep 30, 2020 •
edited by kutyel

Stealing a great idea from partial.lenses, if we provide a special lens which simply calls get and set on the object, we can easily interoperate with Immutable.js without dependencies!
@serras serras self-assigned this Sep 30, 2020
@kutyel kutyel added enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Sep 30, 2020
@serras
Copy link
Collaborator Author

serras commented Sep 30, 2020

This would also work for Map

@serras
Copy link
Collaborator Author

serras commented Sep 30, 2020

We should also check that values works for all these. Otherwise, it should be as easy as changing the getter in values to [...obj.values()], so it works everywhere an iterator can be obtained.

@bangn
Copy link
Contributor

bangn commented Oct 2, 2020

Im new to opticsjs source code as well as lense 😬. Any pointer where should I look into 🤔?

@serras serras mentioned this issue Oct 4, 2020
Merged
@kutyel kutyel assigned bangn and unassigned serras Oct 4, 2020
@kutyel kutyel mentioned this issue Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lens): add get/set lenses [WIP] bangn/optics.js
3 participants
@serras @bangn @kutyel