Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImageBuildSpec work with enclave edits #2382

Open
tedim52 opened this issue Apr 17, 2024 · 0 comments
Open

Make ImageBuildSpec work with enclave edits #2382

tedim52 opened this issue Apr 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tedim52
Copy link
Contributor

tedim52 commented Apr 17, 2024

Background & motivation

Right now if you use an ImageBuildSpec like so:

def run(plan, args):
     plan.add_service(name="service", config=ServiceConfig(
           image=ImageBuildSpec(
                  build_context_dir="./Dockerfile",
          )
      )
    )

Desired behaviour

If you run an enclave, the docker image is built and the service starts off of it.

Ideally, if I make a change to the underlying code the docker image containerizes, I can leverage enclave edits to only restart the service with the rebuilt image.

However, right now this isn't detected by our interpreter so rerunning the package will not detect an update on add_service and not rerun the service, as desired.

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

What area of the product does this pertain to?

Other: anything not covered by the above

@github-actions github-actions bot added the painful Painful bug label Apr 17, 2024
@tedim52 tedim52 added bug Something isn't working and removed painful Painful bug feature request labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant