Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option to load MYSQL_PASS from file instead of ENV #55

Open
garygan89 opened this issue Aug 26, 2021 · 0 comments
Open

Allow option to load MYSQL_PASS from file instead of ENV #55

garygan89 opened this issue Aug 26, 2021 · 0 comments
Labels
component/backend Related to backend component component/helm Related to helm charts good first issue Good for newcomers kind/enhancement improvement to an existing capability skill/helm

Comments

@garygan89
Copy link

Is your feature request related to a problem? Please describe.

No. But having the option to load password from file would allow easy integration with external centralized secret storage such as Hashicorp Vault. This is great for operator that do not want to store credentials in k8s etcd as Secret (which is unencrypted by default), and rely on external vault service.

The Vault Agent Injector can automatically mount the secret as a file to the kubevious pod, which the path can then sent to the arguments.

Describe the solution you'd like

Allow passing argument such as the following to load from file

--mysql-password-from-file=/vault/secrets/mysql-pass

If the file is not specified, then fallback to ENV or string literal --mysql-password-literal=myawesomepassword

Describe alternatives you've considered

Patch the Deployment with Hashicorp-vault-agent-injector annotations to mount, then template it to ENV.

Additional context

None

@rubenhak rubenhak added component/backend Related to backend component kind/enhancement improvement to an existing capability component/helm Related to helm charts labels Aug 26, 2021
@rubenhak rubenhak added the good first issue Good for newcomers label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/backend Related to backend component component/helm Related to helm charts good first issue Good for newcomers kind/enhancement improvement to an existing capability skill/helm
Projects
None yet
Development

No branches or pull requests

2 participants